diff mbox

flite: disable ALSA support

Message ID 1449248389-33123-1-git-send-email-Vincent.Riera@imgtec.com
State Superseded
Headers show

Commit Message

Vicente Olivert Riera Dec. 4, 2015, 4:59 p.m. UTC
Upstream says that ALSA support in flite is broken for earlier versions:

"Seems the alsa code I have breaks on earlier versions I'm not sure what
the threshold version is, but made this depend on the one I know -- you
can still specific --with-audio=alsa"

So let's disable it. It will prevent failures like this one:

/br/output/host/usr/bin/mipsel-linux-gcc -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os -Wall -o
../bin/find_sts find_sts_main.o -L../build/mipsel-linux-uclibc/lib
-lflite -lm
../build/mipsel-linux-uclibc/lib/libflite.a(audio.o): In function
`audio_open':
audio.c:(.text+0x1c): undefined reference to `audio_open_oss'

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/flite/flite.mk | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Peter Korsgaard Dec. 4, 2015, 8:37 p.m. UTC | #1
>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:

 > Upstream says that ALSA support in flite is broken for earlier versions:
 > "Seems the alsa code I have breaks on earlier versions I'm not sure what
 > the threshold version is, but made this depend on the one I know -- you
 > can still specific --with-audio=alsa"

But we have the newest alsa-lib release in Buildroot, right?


> So let's disable it. It will prevent failures like this one:

 > /br/output/host/usr/bin/mipsel-linux-gcc -D_LARGEFILE_SOURCE
 > -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -Os -Wall -o
 > ../bin/find_sts find_sts_main.o -L../build/mipsel-linux-uclibc/lib
 > -lflite -lm
 > ../build/mipsel-linux-uclibc/lib/libflite.a(audio.o): In function
 > `audio_open':
 > audio.c:(.text+0x1c): undefined reference to `audio_open_oss'

This sounds more like it is building without alsa support. From
flite-1.4-release/src/audio/native_audio.h:

#ifdef CST_AUDIO_LINUX

#define AUDIO_OPEN_NATIVE audio_open_oss
..

#endif

#ifdef CST_AUDIO_ALSA

#define AUDIO_OPEN_NATIVE audio_open_alsa
..

#endif

Could you check config.log why it fails?
diff mbox

Patch

diff --git a/package/flite/flite.mk b/package/flite/flite.mk
index 611e334..c5d7828 100644
--- a/package/flite/flite.mk
+++ b/package/flite/flite.mk
@@ -36,11 +36,6 @@  FLITE_DEPENDENCIES = host-pkgconf
 # shared libraries.
 FLITE_MAKE = $(MAKE1)
 
-ifeq ($(BR2_PACKAGE_ALSA_LIB),y)
-FLITE_DEPENDENCIES += alsa-lib
-FLITE_CONF_OPTS += --with-audio=alsa
-else
-FLITE_CONF_OPTS += --with-audio=oss
-endif
+FLITE_CONF_OPTS = --with-audio=oss
 
 $(eval $(autotools-package))