| Message ID | 1449206553-26133-1-git-send-email-vz@mleia.com |
|---|---|
| State | Superseded |
| Headers | show |
On Friday 04 December 2015 07:22:33 Vladimir Zapolskiy wrote: > LPC32xx SoC has two independent PWM controllers, they have different > clock parents, clock gates and slightly different controls, each of > these two PWM controllers has one output channel. > > The change updates device tree binding documentation to reflect two PWM > devices. > > Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> > The change looks reasonable, but I think you should clarify that this is an incompatible change, and do it in the same patch as the corresponding change to set 'npwms' to 1 in the driver. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Dec 04, 2015 at 07:22:33AM +0200, Vladimir Zapolskiy wrote: > LPC32xx SoC has two independent PWM controllers, they have different > clock parents, clock gates and slightly different controls, each of > these two PWM controllers has one output channel. > > The change updates device tree binding documentation to reflect two PWM > devices. > > Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> > --- > Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt b/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt > index cfe1db3..ab0907d 100644 > --- a/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt > +++ b/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt > @@ -8,5 +8,10 @@ Examples: > > pwm@0x4005C000 { > compatible = "nxp,lpc3220-pwm"; > - reg = <0x4005C000 0x8>; > + reg = <0x4005C000 0x4>; > +}; > + > +pwm@0x4005C004 { Remove the '0x' and use lower case hex chars. Rob > + compatible = "nxp,lpc3220-pwm"; > + reg = <0x4005C004 0x4>; > }; > -- > 2.1.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt b/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt index cfe1db3..ab0907d 100644 --- a/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt +++ b/Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt @@ -8,5 +8,10 @@ Examples: pwm@0x4005C000 { compatible = "nxp,lpc3220-pwm"; - reg = <0x4005C000 0x8>; + reg = <0x4005C000 0x4>; +}; + +pwm@0x4005C004 { + compatible = "nxp,lpc3220-pwm"; + reg = <0x4005C004 0x4>; };
LPC32xx SoC has two independent PWM controllers, they have different clock parents, clock gates and slightly different controls, each of these two PWM controllers has one output channel. The change updates device tree binding documentation to reflect two PWM devices. Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> --- Documentation/devicetree/bindings/pwm/lpc32xx-pwm.txt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)