diff mbox

[U-Boot] dm: core: Enable SPL_SIMPLE_BUS by default

Message ID a2fba3001b23b8b231b5ea03fe2a6ff8402cbbd8.1448955594.git.michal.simek@xilinx.com
State Accepted
Delegated to: Michal Simek
Headers show

Commit Message

Michal Simek Dec. 1, 2015, 7:39 a.m. UTC
This option is needed for all SoCs which have nodes on bus. Without
enabling this drivers are not found and probed.
Issue was found on Zynq MMC probe.
Enable this option by default.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 drivers/core/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Roese Dec. 1, 2015, 7:46 a.m. UTC | #1
Hi Michal,

On 01.12.2015 08:39, Michal Simek wrote:
> This option is needed for all SoCs which have nodes on bus. Without
> enabling this drivers are not found and probed.
> Issue was found on Zynq MMC probe.
> Enable this option by default.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>   drivers/core/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig
> index 15681df6d379..74eee1066092 100644
> --- a/drivers/core/Kconfig
> +++ b/drivers/core/Kconfig
> @@ -115,7 +115,7 @@ config SIMPLE_BUS
>   config SPL_SIMPLE_BUS
>   	bool "Support simple-bus driver in SPL"
>   	depends on SPL_DM && SPL_OF_CONTROL
> -	default n
> +	default y
>   	help
>   	  Supports the 'simple-bus' driver, which is used on some systems
>   	  in SPL.

I stumbled over this missing option while porting DM_SPL to mvebu
as well. So:

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan
Michal Simek Dec. 1, 2015, 10:22 a.m. UTC | #2
On 1.12.2015 08:46, Stefan Roese wrote:
> Hi Michal,
> 
> On 01.12.2015 08:39, Michal Simek wrote:
>> This option is needed for all SoCs which have nodes on bus. Without
>> enabling this drivers are not found and probed.
>> Issue was found on Zynq MMC probe.
>> Enable this option by default.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>>   drivers/core/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig
>> index 15681df6d379..74eee1066092 100644
>> --- a/drivers/core/Kconfig
>> +++ b/drivers/core/Kconfig
>> @@ -115,7 +115,7 @@ config SIMPLE_BUS
>>   config SPL_SIMPLE_BUS
>>       bool "Support simple-bus driver in SPL"
>>       depends on SPL_DM && SPL_OF_CONTROL
>> -    default n
>> +    default y
>>       help
>>         Supports the 'simple-bus' driver, which is used on some systems
>>         in SPL.
> 
> I stumbled over this missing option while porting DM_SPL to mvebu
> as well. So:
> 
> Reviewed-by: Stefan Roese <sr@denx.de>

yep. btw: I have added you to cc to one more email regarding SPL.

Thanks,
Michal
Simon Glass Dec. 1, 2015, 4:32 p.m. UTC | #3
On 1 December 2015 at 00:39, Michal Simek <michal.simek@xilinx.com> wrote:
> This option is needed for all SoCs which have nodes on bus. Without
> enabling this drivers are not found and probed.
> Issue was found on Zynq MMC probe.
> Enable this option by default.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>  drivers/core/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks.

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox

Patch

diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig
index 15681df6d379..74eee1066092 100644
--- a/drivers/core/Kconfig
+++ b/drivers/core/Kconfig
@@ -115,7 +115,7 @@  config SIMPLE_BUS
 config SPL_SIMPLE_BUS
 	bool "Support simple-bus driver in SPL"
 	depends on SPL_DM && SPL_OF_CONTROL
-	default n
+	default y
 	help
 	  Supports the 'simple-bus' driver, which is used on some systems
 	  in SPL.