| Message ID | 20100603112721.GD24909@host-a-55.ustcsz.edu.cn |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, 2010-06-03 at 19:27 +0800, Junchang Wang wrote:
> Writting "cmd" into "CounterAddrLow" twice is redundant.
[...]
I assume you've checked this against the datasheets for all 20 variants
of this hardware?
Ben.
From: Junchang Wang <junchangwang@gmail.com> Date: Thu, 3 Jun 2010 19:27:23 +0800 > Writting "cmd" into "CounterAddrLow" twice is redundant. > > Signed-off-by: Junchang Wang <junchangwang@gmail.com> I definitely think this is being done on purpose. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 217e709..e0a77a0 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -1207,7 +1207,6 @@ static void rtl8169_update_counters(struct net_device *dev) RTL_W32(CounterAddrHigh, (u64)paddr >> 32); cmd = (u64)paddr & DMA_BIT_MASK(32); - RTL_W32(CounterAddrLow, cmd); RTL_W32(CounterAddrLow, cmd | CounterDump); while (wait--) {
Writting "cmd" into "CounterAddrLow" twice is redundant. Signed-off-by: Junchang Wang <junchangwang@gmail.com> --- drivers/net/r8169.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) -- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html