From patchwork Thu Jun 3 11:27:23 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Junchang Wang X-Patchwork-Id: 54481 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 139A3B7D16 for ; Thu, 3 Jun 2010 21:27:27 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751229Ab0FCL1X (ORCPT ); Thu, 3 Jun 2010 07:27:23 -0400 Received: from mail-pz0-f185.google.com ([209.85.222.185]:45612 "EHLO mail-pz0-f185.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748Ab0FCL1W (ORCPT ); Thu, 3 Jun 2010 07:27:22 -0400 Received: by pzk15 with SMTP id 15so3005328pzk.15 for ; Thu, 03 Jun 2010 04:27:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject :message-id:mail-followup-to:mime-version:content-type :content-disposition:user-agent; bh=rhAzqCSJMqcwxhETN78gaLVJd6uNBEd9OKxQK0w14tE=; b=fasVvGcxjXQwbmv5LqVQ4cG4s+ztns2v8uy68vtLPRolMJRUHS1udob1JFo/q1xlxh 0RAivvvO4rqGcqglpTCES7Pz7TYrBTiujgpdW3HdqfpxZwF10U/p3DokNrvoFm05YYlf 885ixxV+tE8Jv1T8zWGa9kO2Y2M5CkhHOi2yc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:mime-version :content-type:content-disposition:user-agent; b=fW4RW7+R8QGThqjGEgCr5Wct2iYLbCNEwqrxM6Sb1+S3r2TZ/AiBqOipzow95f47VJ p4wm3DJB/xzDMTmWGz+wAJ4S2lLjDVAi/k2wix8VNLGghbwL3/5mPg52N+VzUk+5GfjI yqqrZuzqZxwngHd5zKIww6j2Jlh0YW0qArIDQ= Received: by 10.141.108.3 with SMTP id k3mr7973742rvm.141.1275564441812; Thu, 03 Jun 2010 04:27:21 -0700 (PDT) Received: from host-a-55.ustcsz.edu.cn ([58.211.218.74]) by mx.google.com with ESMTPS id l29sm224575rvb.4.2010.06.03.04.27.15 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 03 Jun 2010 04:27:18 -0700 (PDT) Date: Thu, 3 Jun 2010 19:27:23 +0800 From: Junchang Wang To: romieu@fr.zoreil.com Cc: davem@davemloft.net, netdev@vger.kernel.org Subject: [Patch 2/2]r8169: remove redundant RTL_W32 Message-ID: <20100603112721.GD24909@host-a-55.ustcsz.edu.cn> Mail-Followup-To: romieu@fr.zoreil.com, davem@davemloft.net, netdev@vger.kernel.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Writting "cmd" into "CounterAddrLow" twice is redundant. Signed-off-by: Junchang Wang --- drivers/net/r8169.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) -- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 217e709..e0a77a0 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -1207,7 +1207,6 @@ static void rtl8169_update_counters(struct net_device *dev) RTL_W32(CounterAddrHigh, (u64)paddr >> 32); cmd = (u64)paddr & DMA_BIT_MASK(32); - RTL_W32(CounterAddrLow, cmd); RTL_W32(CounterAddrLow, cmd | CounterDump); while (wait--) {