| Message ID | 1447454404-10754-1-git-send-email-mdroth@linux.vnet.ibm.com |
|---|---|
| State | New |
| Headers | show |
On 13 November 2015 at 22:40, Michael Roth <mdroth@linux.vnet.ibm.com> wrote: > The following changes since commit 8337c6cbc37c6b2184f41bab3eaff47d5e68012a: > > Update version for v2.5.0-rc0 release (2015-11-13 17:10:36 +0000) > > are available in the git repository at: > > git://github.com/mdroth/qemu.git tags/qga-pull-2015-11-13-tag > > for you to fetch changes up to 8144e432d8c8e801a906c126afc1333985fad0ce: > > qga: allow to lookup in PATH from the passed envp for guest-exec (2015-11-13 16:31:32 -0600) > > ---------------------------------------------------------------- > qemu-ga patch queue for 2.5 > > * fixes for guest-exec gspawn() usage: > - inherit default lookup path by default instead of > explicitly defining it as being empty. > - don't inherit default PATH when PATH/ENV are explicit > > ---------------------------------------------------------------- Hi. I'm afraid this doesn't build against our minimum supported glib version: /Users/pm215/src/qemu-for-merges/qga/commands.c:403:35: error: use of undeclared identifier 'G_SPAWN_SEARCH_PATH_FROM_ENVP' Looks like that feature was only added in glib 2.34 or thereabouts. thanks -- PMM
Quoting Peter Maydell (2015-11-16 06:09:17) > On 13 November 2015 at 22:40, Michael Roth <mdroth@linux.vnet.ibm.com> wrote: > > The following changes since commit 8337c6cbc37c6b2184f41bab3eaff47d5e68012a: > > > > Update version for v2.5.0-rc0 release (2015-11-13 17:10:36 +0000) > > > > are available in the git repository at: > > > > git://github.com/mdroth/qemu.git tags/qga-pull-2015-11-13-tag > > > > for you to fetch changes up to 8144e432d8c8e801a906c126afc1333985fad0ce: > > > > qga: allow to lookup in PATH from the passed envp for guest-exec (2015-11-13 16:31:32 -0600) > > > > ---------------------------------------------------------------- > > qemu-ga patch queue for 2.5 > > > > * fixes for guest-exec gspawn() usage: > > - inherit default lookup path by default instead of > > explicitly defining it as being empty. > > - don't inherit default PATH when PATH/ENV are explicit > > > > ---------------------------------------------------------------- > > Hi. I'm afraid this doesn't build against our minimum supported > glib version: > > /Users/pm215/src/qemu-for-merges/qga/commands.c:403:35: error: use of > undeclared identifier 'G_SPAWN_SEARCH_PATH_FROM_ENVP' > > Looks like that feature was only added in glib 2.34 or thereabouts. Sorry, I noticed this after submitting. I commented on it in response to patch 2, but probably should've posted a top-level reply. I've added a version check (it appears to be 2.33.2) in v2, but I'm trying to get 1 more qga fix ("makefile: fix w32 install target for qemu-ga") in before resubmitting. > > thanks > -- PMM >
The following changes since commit 8337c6cbc37c6b2184f41bab3eaff47d5e68012a: Update version for v2.5.0-rc0 release (2015-11-13 17:10:36 +0000) are available in the git repository at: git://github.com/mdroth/qemu.git tags/qga-pull-2015-11-13-tag for you to fetch changes up to 8144e432d8c8e801a906c126afc1333985fad0ce: qga: allow to lookup in PATH from the passed envp for guest-exec (2015-11-13 16:31:32 -0600) ---------------------------------------------------------------- qemu-ga patch queue for 2.5 * fixes for guest-exec gspawn() usage: - inherit default lookup path by default instead of explicitly defining it as being empty. - don't inherit default PATH when PATH/ENV are explicit ---------------------------------------------------------------- Yuri Pudgorodskiy (2): qga: fix for default env processing for guest-exec qga: allow to lookup in PATH from the passed envp for guest-exec qga/commands.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)