diff mbox

kvm/powerpc: fix a build error in e500_tlb.c

Message ID 1275544348-3469-1-git-send-email-haokexin@gmail.com (mailing list archive)
State Not Applicable
Headers show

Commit Message

Kevin Hao June 3, 2010, 5:52 a.m. UTC
We use the wrong number arguments when invoking trace_kvm_stlb_inval,
and cause the following build error.
arch/powerpc/kvm/e500_tlb.c: In function 'kvmppc_e500_stlbe_invalidate':
arch/powerpc/kvm/e500_tlb.c:230: error: too many arguments to function 'trace_kvm_stlb_inval'

Signed-off-by: Kevin Hao <haokexin@gmail.com>
---
 arch/powerpc/kvm/e500_tlb.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

Comments

Alexander Graf June 4, 2010, 2:08 p.m. UTC | #1
On 03.06.2010, at 07:52, Kevin Hao wrote:

> We use the wrong number arguments when invoking trace_kvm_stlb_inval,
> and cause the following build error.
> arch/powerpc/kvm/e500_tlb.c: In function 'kvmppc_e500_stlbe_invalidate':
> arch/powerpc/kvm/e500_tlb.c:230: error: too many arguments to function 'trace_kvm_stlb_inval'

Liu, I'd like to get an ack from you here.

Alex
Liu Yu-B13201 June 7, 2010, 4:14 a.m. UTC | #2
> -----Original Message-----
> From: kvm-owner@vger.kernel.org 
> [mailto:kvm-owner@vger.kernel.org] On Behalf Of Alexander Graf
> Sent: Friday, June 04, 2010 10:08 PM
> To: Kevin Hao
> Cc: Marcelo Tosatti; Kumar Gala; Avi Kivity; 
> kvm@vger.kernel.org list; linuxppc-dev@ozlabs.org; Liu Yu-B13201
> Subject: Re: [PATCH] kvm/powerpc: fix a build error in e500_tlb.c
> 
> 
> On 03.06.2010, at 07:52, Kevin Hao wrote:
> 
> > We use the wrong number arguments when invoking 
> trace_kvm_stlb_inval,
> > and cause the following build error.
> > arch/powerpc/kvm/e500_tlb.c: In function 
> 'kvmppc_e500_stlbe_invalidate':
> > arch/powerpc/kvm/e500_tlb.c:230: error: too many arguments 
> to function 'trace_kvm_stlb_inval'
> 
> Liu, I'd like to get an ack from you here.
> 

Seems commit e43f2f741a49483034bf968841275cfa553a4cb3 has solved this.
diff mbox

Patch

diff --git a/arch/powerpc/kvm/e500_tlb.c b/arch/powerpc/kvm/e500_tlb.c
index 21011e1..1261a21 100644
--- a/arch/powerpc/kvm/e500_tlb.c
+++ b/arch/powerpc/kvm/e500_tlb.c
@@ -226,8 +226,7 @@  static void kvmppc_e500_stlbe_invalidate(struct kvmppc_vcpu_e500 *vcpu_e500,
 
 	kvmppc_e500_shadow_release(vcpu_e500, tlbsel, esel);
 	stlbe->mas1 = 0;
-	trace_kvm_stlb_inval(index_of(tlbsel, esel), stlbe->mas1, stlbe->mas2,
-			     stlbe->mas3, stlbe->mas7);
+	trace_kvm_stlb_inval(index_of(tlbsel, esel));
 }
 
 static void kvmppc_e500_tlb1_invalidate(struct kvmppc_vcpu_e500 *vcpu_e500,