diff mbox

[U-Boot,13/17] board/keymile/km82xx: setting dip_switch 3 and 4 will run bootloader

Message ID 1447426768-23226-14-git-send-email-valentin.longchamp@keymile.com
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

Valentin Longchamp Nov. 13, 2015, 2:59 p.m. UTC
From: Bagavathiannan Palanisamy <Bagavathiannan.Palanisamy@keymile.com>

Setting dip_switch 3 and 4 also will run bootloader in COGE3 and COGE6
It is required remove local mgmt IP address, when DIP Switch PIN3 is
enabled. DIP Switch 4 also enabled to avoid u-boot update in future
for DIP switch enhancements.

Signed-off-by: Bagavathiannan Palanisamy <Bagavathiannan.Palanisamy@keymile.com>
Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
---

 board/keymile/km82xx/km82xx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Heiko Schocher Nov. 16, 2015, 11:04 a.m. UTC | #1
Hello Valentin,

Am 13.11.2015 um 15:59 schrieb Valentin Longchamp:
> From: Bagavathiannan Palanisamy <Bagavathiannan.Palanisamy@keymile.com>
>
> Setting dip_switch 3 and 4 also will run bootloader in COGE3 and COGE6
> It is required remove local mgmt IP address, when DIP Switch PIN3 is
> enabled. DIP Switch 4 also enabled to avoid u-boot update in future
> for DIP switch enhancements.
>
> Signed-off-by: Bagavathiannan Palanisamy <Bagavathiannan.Palanisamy@keymile.com>
> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
> ---
>
>   board/keymile/km82xx/km82xx.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)


Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/board/keymile/km82xx/km82xx.c b/board/keymile/km82xx/km82xx.c
> index 01a3c20..9e285ec 100644
> --- a/board/keymile/km82xx/km82xx.c
> +++ b/board/keymile/km82xx/km82xx.c
> @@ -329,8 +329,8 @@ int last_stage_init(void)
>
>   	dip_switch = in_8(&base->mswitch);
>   	dip_switch &= BFTICU_DIPSWITCH_MASK;
> -	/* dip switch 'full reset' or 'db erase' */
> -	if (dip_switch & 0x1 || dip_switch & 0x2) {
> +	/* dip switch 'full reset' or 'db erase' or 'Local mgmt IP' or any */
> +	if (dip_switch != 0) {
>   		/* start bootloader */
>   		puts("DIP:   Enabled\n");
>   		setenv("actual_bank", "0");
>
diff mbox

Patch

diff --git a/board/keymile/km82xx/km82xx.c b/board/keymile/km82xx/km82xx.c
index 01a3c20..9e285ec 100644
--- a/board/keymile/km82xx/km82xx.c
+++ b/board/keymile/km82xx/km82xx.c
@@ -329,8 +329,8 @@  int last_stage_init(void)
 
 	dip_switch = in_8(&base->mswitch);
 	dip_switch &= BFTICU_DIPSWITCH_MASK;
-	/* dip switch 'full reset' or 'db erase' */
-	if (dip_switch & 0x1 || dip_switch & 0x2) {
+	/* dip switch 'full reset' or 'db erase' or 'Local mgmt IP' or any */
+	if (dip_switch != 0) {
 		/* start bootloader */
 		puts("DIP:   Enabled\n");
 		setenv("actual_bank", "0");