| Message ID | 1447401507-6319-1-git-send-email-stefanha@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 13 November 2015 at 07:58, Stefan Hajnoczi <stefanha@redhat.com> wrote: > v3: > * Include "exec/log.h" from translate-a64.c [Peter] > > v2: > * Add missing log.py file [Peter] > > The following changes since commit 74fcbd22d20a2fbc1a47a7b00cce5bf98fd7be5f: > > hw/misc: Add support for ADC controller in Xilinx Zynq 7000 (2015-11-12 21:30:42 +0000) > > are available in the git repository at: > > git://github.com/stefanha/qemu.git tags/tracing-pull-request > > for you to fetch changes up to de332788d7c626fce31f6baebab807df5a7410e1: > > log: add "-d trace:PATTERN" (2015-11-13 15:52:57 +0800) w32 fails to build with the same 'ssize_t vs signed size_t for %zd' thing that hit somebody else's changes earlier this week: In file included from /home/petmay01/linaro/qemu-for-merges/include/trace.h:4, from /home/petmay01/linaro/qemu-for-merges/util/oslib-win32.c:38: ./trace/generated-tracers.h: In function ‘trace_virtio_console_flush_buf’: ./trace/generated-tracers.h:240: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 8 has type ‘ssize_t’ CC util/bitops.o ./trace/generated-tracers.h: In function ‘trace_usb_ohci_iso_td_so’: ./trace/generated-tracers.h:2784: warning: format ‘%zu’ expects type ‘size_t’, but argument 11 has type ‘ssize_t’ ./trace/generated-tracers.h: In function ‘trace_usb_ohci_iso_td_data_overrun’: ./trace/generated-tracers.h:2796: warning: format ‘%zu’ expects type ‘size_t’, but argument 7 has type ‘ssize_t’ CC util/hbitmap.o CC util/fifo8.o ./trace/generated-tracers.h: In function ‘trace_spice_vmc_write’: ./trace/generated-tracers.h:6492: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 6 has type ‘ssize_t’ CC util/acl.o CC util/error.o ./trace/generated-tracers.h: In function ‘trace_v9fs_read_return’: ./trace/generated-tracers.h:10344: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 9 has type ‘ssize_t’ ./trace/generated-tracers.h: In function ‘trace_v9fs_readdir_return’: ./trace/generated-tracers.h:10368: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 9 has type ‘ssize_t’ ./trace/generated-tracers.h: In function ‘trace_v9fs_write_return’: ./trace/generated-tracers.h:10392: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 9 has type ‘ssize_t’ CC util/qemu-error.o CC util/id.o CC util/iov.o cc1: warnings being treated as errors In file included from /home/petmay01/linaro/qemu-for-merges/include/trace.h:4, from /home/petmay01/linaro/qemu-for-merges/util/hbitmap.c:18: ./trace/generated-tracers.h: In function ‘trace_virtio_console_flush_buf’: ./trace/generated-tracers.h:240: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 8 has type ‘ssize_t’ CC util/qemu-config.o ./trace/generated-tracers.h: In function ‘trace_usb_ohci_iso_td_so’: ./trace/generated-tracers.h:2784: warning: format ‘%zu’ expects type ‘size_t’, but argument 11 has type ‘ssize_t’ ./trace/generated-tracers.h: In function ‘trace_usb_ohci_iso_td_data_overrun’: ./trace/generated-tracers.h:2796: warning: format ‘%zu’ expects type ‘size_t’, but argument 7 has type ‘ssize_t’ make: *** [util/oslib-win32.o] Error 1 make: *** Waiting for unfinished jobs.... ./trace/generated-tracers.h: In function ‘trace_spice_vmc_write’: ./trace/generated-tracers.h:6492: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 6 has type ‘ssize_t’ ./trace/generated-tracers.h: In function ‘trace_v9fs_read_return’: ./trace/generated-tracers.h:10344: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 9 has type ‘ssize_t’ ./trace/generated-tracers.h: In function ‘trace_v9fs_readdir_return’: ./trace/generated-tracers.h:10368: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 9 has type ‘ssize_t’ ./trace/generated-tracers.h: In function ‘trace_v9fs_write_return’: ./trace/generated-tracers.h:10392: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 9 has type ‘ssize_t’ make: *** [util/hbitmap.o] Error 1 make: Leaving directory `/home/petmay01/linaro/qemu-for-merges/build/w32' I also now get a handful of extra warnings in the 'make check' output: /aarch64/qom/xilinx-zynq-a9: OK /aarch64/qom/xlnx-ep108: WARNING: RAM size 8000000 is small for EP108OK /aarch64/qom/vexpress-a9: OK (note the missing newline...) TEST: tests/qom-test... (pid=19738) /microblaze/qom/none: OK /microblaze/qom/petalogix-s3adsp1800: Invalid MicroBlaze version number: (null) OK /microblaze/qom/petalogix-ml605: Invalid MicroBlaze version number: (null) OK thanks -- PMM
On Fri, Nov 13, 2015 at 6:30 PM, Peter Maydell <peter.maydell@linaro.org> wrote: > On 13 November 2015 at 07:58, Stefan Hajnoczi <stefanha@redhat.com> wrote: >> v3: >> * Include "exec/log.h" from translate-a64.c [Peter] >> >> v2: >> * Add missing log.py file [Peter] >> >> The following changes since commit 74fcbd22d20a2fbc1a47a7b00cce5bf98fd7be5f: >> >> hw/misc: Add support for ADC controller in Xilinx Zynq 7000 (2015-11-12 21:30:42 +0000) >> >> are available in the git repository at: >> >> git://github.com/stefanha/qemu.git tags/tracing-pull-request >> >> for you to fetch changes up to de332788d7c626fce31f6baebab807df5a7410e1: >> >> log: add "-d trace:PATTERN" (2015-11-13 15:52:57 +0800) > > w32 fails to build with the same 'ssize_t vs signed size_t for %zd' > thing that hit somebody else's changes earlier this week: ... > I also now get a handful of extra warnings in the 'make check' output: As mentioned on IRC, I'm dropping this pull request. I'll send a new pull request early next week for -rc1. It will only contain bug fixes. Too many fixes are accumulating on top of the patches. I'm going to bounce the original series and merge it, once fixed, for QEMU 2.6. Stefan
On 13 November 2015 at 10:30, Peter Maydell <peter.maydell@linaro.org> wrote: > I also now get a handful of extra warnings in the 'make check' output: > > /aarch64/qom/xilinx-zynq-a9: OK > /aarch64/qom/xlnx-ep108: > WARNING: RAM size 8000000 is small for EP108OK > /aarch64/qom/vexpress-a9: OK > > (note the missing newline...) > > TEST: tests/qom-test... (pid=19738) > /microblaze/qom/none: OK > /microblaze/qom/petalogix-s3adsp1800: > Invalid MicroBlaze version number: (null) > OK > /microblaze/qom/petalogix-ml605: > Invalid MicroBlaze version number: (null) > OK Peter/Alistair/Edgar: this patchset of Stefan's has now been deferred until 2.6, but you might want to look into the log warning issues it exposed (the missing newline, attempt to print NULL, and maybe whether the warnings should really be printed for a simple attempt to start the board with no arguments). thanks -- PMM
On 13/11/2015 11:30, Peter Maydell wrote: > I also now get a handful of extra warnings in the 'make check' output: > > /aarch64/qom/xilinx-zynq-a9: OK > /aarch64/qom/xlnx-ep108: > WARNING: RAM size 8000000 is small for EP108OK > /aarch64/qom/vexpress-a9: OK This could be an off-by-one. > (note the missing newline...) > > TEST: tests/qom-test... (pid=19738) > /microblaze/qom/none: OK > /microblaze/qom/petalogix-s3adsp1800: > Invalid MicroBlaze version number: (null) > OK > /microblaze/qom/petalogix-ml605: > Invalid MicroBlaze version number: (null) > OK These seem like a genuine problem too. Peter C. or Edgar, can you look into them? Paolo
On Fri, Nov 13, 2015 at 11:28:41AM +0000, Peter Maydell wrote: > On 13 November 2015 at 10:30, Peter Maydell <peter.maydell@linaro.org> wrote: > > I also now get a handful of extra warnings in the 'make check' output: > > > > /aarch64/qom/xilinx-zynq-a9: OK > > /aarch64/qom/xlnx-ep108: > > WARNING: RAM size 8000000 is small for EP108OK > > /aarch64/qom/vexpress-a9: OK > > > > (note the missing newline...) > > > > TEST: tests/qom-test... (pid=19738) > > /microblaze/qom/none: OK > > /microblaze/qom/petalogix-s3adsp1800: > > Invalid MicroBlaze version number: (null) > > OK > > /microblaze/qom/petalogix-ml605: > > Invalid MicroBlaze version number: (null) > > OK > > Peter/Alistair/Edgar: this patchset of Stefan's has now been deferred > until 2.6, but you might want to look into the log warning issues > it exposed (the missing newline, attempt to print NULL, and maybe > whether the warnings should really be printed for a simple attempt > to start the board with no arguments). > Thanks, I've posted patches to fix the MicroBlaze warings on the list. I don't know what the inention was with the E1P08 warning.. IMO we can remove it... Cheers, Edgar
On Fri, Nov 13, 2015 at 10:33 PM, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote: > On Fri, Nov 13, 2015 at 11:28:41AM +0000, Peter Maydell wrote: >> On 13 November 2015 at 10:30, Peter Maydell <peter.maydell@linaro.org> wrote: >> > I also now get a handful of extra warnings in the 'make check' output: >> > >> > /aarch64/qom/xilinx-zynq-a9: OK >> > /aarch64/qom/xlnx-ep108: >> > WARNING: RAM size 8000000 is small for EP108OK >> > /aarch64/qom/vexpress-a9: OK >> > >> > (note the missing newline...) >> > >> > TEST: tests/qom-test... (pid=19738) >> > /microblaze/qom/none: OK >> > /microblaze/qom/petalogix-s3adsp1800: >> > Invalid MicroBlaze version number: (null) >> > OK >> > /microblaze/qom/petalogix-ml605: >> > Invalid MicroBlaze version number: (null) >> > OK >> >> Peter/Alistair/Edgar: this patchset of Stefan's has now been deferred >> until 2.6, but you might want to look into the log warning issues >> it exposed (the missing newline, attempt to print NULL, and maybe >> whether the warnings should really be printed for a simple attempt >> to start the board with no arguments). >> > > Thanks, > > I've posted patches to fix the MicroBlaze warings on the list. > > I don't know what the inention was with the E1P08 warning.. IMO we > can remove it... The warning is there because the RAM size is user definable, if the user tries to set a size that is too small QEMU will warn them. I sent a patch that fixes up the size check logic. Thanks, Alistair > > Cheers, > Edgar >
On 11/13/2015 01:44 PM, Stefan Hajnoczi wrote: > On Fri, Nov 13, 2015 at 6:30 PM, Peter Maydell <peter.maydell@linaro.org> wrote: >> On 13 November 2015 at 07:58, Stefan Hajnoczi <stefanha@redhat.com> wrote: >>> v3: >>> * Include "exec/log.h" from translate-a64.c [Peter] >>> >>> v2: >>> * Add missing log.py file [Peter] >>> >>> The following changes since commit 74fcbd22d20a2fbc1a47a7b00cce5bf98fd7be5f: >>> >>> hw/misc: Add support for ADC controller in Xilinx Zynq 7000 (2015-11-12 21:30:42 +0000) >>> >>> are available in the git repository at: >>> >>> git://github.com/stefanha/qemu.git tags/tracing-pull-request >>> >>> for you to fetch changes up to de332788d7c626fce31f6baebab807df5a7410e1: >>> >>> log: add "-d trace:PATTERN" (2015-11-13 15:52:57 +0800) >> w32 fails to build with the same 'ssize_t vs signed size_t for %zd' >> thing that hit somebody else's changes earlier this week: > ... >> I also now get a handful of extra warnings in the 'make check' output: > As mentioned on IRC, I'm dropping this pull request. > > I'll send a new pull request early next week for -rc1. It will only > contain bug fixes. > > Too many fixes are accumulating on top of the patches. I'm going to > bounce the original series and merge it, once fixed, for QEMU 2.6. > > Stefan > is it time? Stefan, do you need some help with this serie? Den
On 11/13/2015 10:58 AM, Stefan Hajnoczi wrote: > v3: > * Include "exec/log.h" from translate-a64.c [Peter] > > v2: > * Add missing log.py file [Peter] > > The following changes since commit 74fcbd22d20a2fbc1a47a7b00cce5bf98fd7be5f: > > hw/misc: Add support for ADC controller in Xilinx Zynq 7000 (2015-11-12 21:30:42 +0000) > > are available in the git repository at: > > git://github.com/stefanha/qemu.git tags/tracing-pull-request > > for you to fetch changes up to de332788d7c626fce31f6baebab807df5a7410e1: > > log: add "-d trace:PATTERN" (2015-11-13 15:52:57 +0800) > > ---------------------------------------------------------------- > > ---------------------------------------------------------------- > > Denis V. Lunev (2): > trace: no need to call trace_backend_init in different branches now > log: move qemu-log.c into util/ directory > > Paolo Bonzini (11): > trace: count number of enabled events > trace: track enabled events in a separate array > trace: fix documentation > trace: split trace_init_events out of trace_init_backends > trace: split trace_init_file out of trace_init_backends > trace: add "-trace enable=..." > trace: add "-trace help" > log: do not unnecessarily include qom/cpu.h > trace: convert stderr backend to log > trace: switch default backend to "log" > log: add "-d trace:PATTERN" > > Stefan Hajnoczi (2): > trace: fix make foo-timestamp rules > trace: add make dependencies on tracetool source > > Makefile.objs | 1 - > bsd-user/main.c | 1 + > configure | 6 +- > cpu-exec.c | 1 + > exec.c | 1 + > hw/acpi/cpu_hotplug.c | 1 + > hw/timer/a9gtimer.c | 1 + > include/exec/log.h | 60 +++++++++++ > include/qemu/log.h | 60 +---------- > linux-user/main.c | 1 + > qemu-io.c | 2 +- > qemu-log.c | 177 -------------------------------- > qemu-options.hx | 22 ++-- > qom/cpu.c | 1 + > scripts/tracetool/backend/log.py | 48 +++++++++ > scripts/tracetool/backend/stderr.py | 47 --------- > scripts/tracetool/format/events_c.py | 2 +- > target-alpha/translate.c | 1 + > target-arm/translate-a64.c | 1 + > target-arm/translate.c | 1 + > target-cris/translate.c | 1 + > target-i386/seg_helper.c | 1 + > target-i386/smm_helper.c | 1 + > target-i386/translate.c | 1 + > target-lm32/helper.c | 1 + > target-lm32/translate.c | 1 + > target-m68k/translate.c | 1 + > target-microblaze/helper.c | 1 + > target-microblaze/translate.c | 1 + > target-mips/helper.c | 1 + > target-mips/translate.c | 1 + > target-moxie/translate.c | 1 + > target-openrisc/translate.c | 1 + > target-ppc/mmu-hash32.c | 1 + > target-ppc/mmu-hash64.c | 1 + > target-ppc/mmu_helper.c | 1 + > target-ppc/translate.c | 1 + > target-s390x/translate.c | 1 + > target-sh4/helper.c | 1 + > target-sh4/translate.c | 1 + > target-sparc/int32_helper.c | 1 + > target-sparc/int64_helper.c | 1 + > target-sparc/translate.c | 1 + > target-tilegx/translate.c | 1 + > target-tricore/translate.c | 1 + > target-unicore32/translate.c | 1 + > target-xtensa/translate.c | 1 + > tcg/tcg.c | 1 + > trace/Makefile.objs | 48 +++++---- > trace/control-internal.h | 15 ++- > trace/control.c | 98 +++++++++++++----- > trace/control.h | 44 +++++++- > trace/event-internal.h | 2 - > trace/simple.c | 6 +- > trace/simple.h | 4 +- > translate-all.c | 1 + > util/Makefile.objs | 1 + > util/log.c | 190 +++++++++++++++++++++++++++++++++++ > vl.c | 38 ++++--- > 59 files changed, 537 insertions(+), 373 deletions(-) > create mode 100644 include/exec/log.h > delete mode 100644 qemu-log.c > create mode 100644 scripts/tracetool/backend/log.py > delete mode 100644 scripts/tracetool/backend/stderr.py > create mode 100644 util/log.c > Can I help with this? This series really stuck... Den
On Mon, Dec 21, 2015 at 08:53:26AM +0300, Denis V. Lunev wrote: > On 11/13/2015 01:44 PM, Stefan Hajnoczi wrote: > >On Fri, Nov 13, 2015 at 6:30 PM, Peter Maydell <peter.maydell@linaro.org> wrote: > >>On 13 November 2015 at 07:58, Stefan Hajnoczi <stefanha@redhat.com> wrote: > >>>v3: > >>> * Include "exec/log.h" from translate-a64.c [Peter] > >>> > >>>v2: > >>> * Add missing log.py file [Peter] > >>> > >>>The following changes since commit 74fcbd22d20a2fbc1a47a7b00cce5bf98fd7be5f: > >>> > >>> hw/misc: Add support for ADC controller in Xilinx Zynq 7000 (2015-11-12 21:30:42 +0000) > >>> > >>>are available in the git repository at: > >>> > >>> git://github.com/stefanha/qemu.git tags/tracing-pull-request > >>> > >>>for you to fetch changes up to de332788d7c626fce31f6baebab807df5a7410e1: > >>> > >>> log: add "-d trace:PATTERN" (2015-11-13 15:52:57 +0800) > >>w32 fails to build with the same 'ssize_t vs signed size_t for %zd' > >>thing that hit somebody else's changes earlier this week: > >... > >>I also now get a handful of extra warnings in the 'make check' output: > >As mentioned on IRC, I'm dropping this pull request. > > > >I'll send a new pull request early next week for -rc1. It will only > >contain bug fixes. > > > >Too many fixes are accumulating on top of the patches. I'm going to > >bounce the original series and merge it, once fixed, for QEMU 2.6. > > > >Stefan > > > is it time? > > Stefan, do you need some help with this serie? Hi, I've replied to your original series. Thanks, Stefan