| Message ID | 1447396932-26644-3-git-send-email-l.majewski@majess.pl |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
On Fri, Nov 13, 2015 at 07:42:08AM +0100, Lukasz Majewski wrote: > This code is not processing any data to serial console output and hence > can be replaced with puts. > > Signed-off-by: Lukasz Majewski <l.majewski@majess.pl> No, printf is fine, always. We went over this before and it's not a win to change things.
Hi Tom, > On Fri, Nov 13, 2015 at 07:42:08AM +0100, Lukasz Majewski wrote: > > > This code is not processing any data to serial console output and > > hence can be replaced with puts. > > > > Signed-off-by: Lukasz Majewski <l.majewski@majess.pl> > > No, printf is fine, always. We went over this before and it's not a > win to change things. Ok, I see. Then I will drop this patch. > Best regards, Lukasz Majewski
diff --git a/common/cmd_gpt.c b/common/cmd_gpt.c index 4da2de7..4c71125 100644 --- a/common/cmd_gpt.c +++ b/common/cmd_gpt.c @@ -281,11 +281,11 @@ static int gpt_default(block_dev_desc_t *blk_dev_desc, const char *str_part) &str_disk_guid, &partitions, &part_count); if (ret) { if (ret == -1) - printf("No partition list provided\n"); + puts("No partition list provided\n"); if (ret == -2) - printf("Missing disk guid\n"); + puts("Missing disk guid\n"); if ((ret == -3) || (ret == -4)) - printf("Partition list incomplete\n"); + puts("Partition list incomplete\n"); return -1; }
This code is not processing any data to serial console output and hence can be replaced with puts. Signed-off-by: Lukasz Majewski <l.majewski@majess.pl> --- common/cmd_gpt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)