diff mbox

[U-Boot,v2] omap3: cm-t3517: add board specific get_board_rev()

Message ID 1447161464-29638-1-git-send-email-lifshitz@compulab.co.il
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Dmitry Lifshitz Nov. 10, 2015, 1:17 p.m. UTC
CM-T3517 has several HW revisions.
Add board specific get_board_rev() callback to retrieve revision number.

Signed-off-by: Dmitry Lifshitz <lifshitz@compulab.co.il>
---

 Igor, Tom

 I forgot to add a mailing list address in send-email.
 Resending the patch.

 v2: Make proper use of cl_eeprom_get_board_rev() parameter.

 board/compulab/cm_t3517/cm_t3517.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Igor Grinberg Nov. 10, 2015, 5:33 p.m. UTC | #1
On 11/10/15 15:17, Dmitry Lifshitz wrote:
> CM-T3517 has several HW revisions.
> Add board specific get_board_rev() callback to retrieve revision number.
> 
> Signed-off-by: Dmitry Lifshitz <lifshitz@compulab.co.il>

Reviewed-by: Igor Grinberg <grinberg@compulab.co.il>

> ---
> 
>  Igor, Tom
> 
>  I forgot to add a mailing list address in send-email.
>  Resending the patch.

you may want to use aliases to simplify the stuff, check out doc/git-mailrc.

> 
>  v2: Make proper use of cl_eeprom_get_board_rev() parameter.
> 
>  board/compulab/cm_t3517/cm_t3517.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/board/compulab/cm_t3517/cm_t3517.c b/board/compulab/cm_t3517/cm_t3517.c
> index d1c74db..8aae248 100644
> --- a/board/compulab/cm_t3517/cm_t3517.c
> +++ b/board/compulab/cm_t3517/cm_t3517.c
> @@ -98,6 +98,15 @@ int board_init(void)
>  	return 0;
>  }
>  
> +/*
> + * Routine: get_board_rev
> + * Description: read system revision
> + */
> +u32 get_board_rev(void)
> +{
> +	return cl_eeprom_get_board_rev(CONFIG_SYS_I2C_EEPROM_BUS);
> +};
> +
>  int misc_init_r(void)
>  {
>  	cl_print_pcb_info();
>
Tom Rini Nov. 18, 2015, 10:34 p.m. UTC | #2
On Tue, Nov 10, 2015 at 03:17:44PM +0200, Dmitry Lifshitz wrote:

> CM-T3517 has several HW revisions.
> Add board specific get_board_rev() callback to retrieve revision number.
> 
> Signed-off-by: Dmitry Lifshitz <lifshitz@compulab.co.il>
> Reviewed-by: Igor Grinberg <grinberg@compulab.co.il>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/board/compulab/cm_t3517/cm_t3517.c b/board/compulab/cm_t3517/cm_t3517.c
index d1c74db..8aae248 100644
--- a/board/compulab/cm_t3517/cm_t3517.c
+++ b/board/compulab/cm_t3517/cm_t3517.c
@@ -98,6 +98,15 @@  int board_init(void)
 	return 0;
 }
 
+/*
+ * Routine: get_board_rev
+ * Description: read system revision
+ */
+u32 get_board_rev(void)
+{
+	return cl_eeprom_get_board_rev(CONFIG_SYS_I2C_EEPROM_BUS);
+};
+
 int misc_init_r(void)
 {
 	cl_print_pcb_info();