| Message ID | 1446802414-31132-3-git-send-email-hl@rock-chips.com |
|---|---|
| State | Superseded |
| Delegated to: | Simon Glass |
| Headers | show |
Hi, On 6 November 2015 at 01:33, Lin Huang <hl@rock-chips.com> wrote: > since different rockchip SOC have different size of SRAM, > So the size SYS_MALLOC_F_LEN may different, so move this > config to rk3288 own Kconfig > > Signed-off-by: Lin Huang <hl@rock-chips.com> > --- > Changes in v1: None > Changes in v2: None > Changes in v3: None > > arch/arm/mach-rockchip/Kconfig | 3 --- > arch/arm/mach-rockchip/rk3288/Kconfig | 3 +++ > 2 files changed, 3 insertions(+), 3 deletions(-) I thought I Acked this patch, and several others. To avoid me having to review everything again, can you please pick those up and send a new version? Regards, Simon
Hi Simon, On 06/11/15 20:08, Simon Glass wrote: > Hi, > > On 6 November 2015 at 01:33, Lin Huang <hl@rock-chips.com> wrote: >> since different rockchip SOC have different size of SRAM, >> So the size SYS_MALLOC_F_LEN may different, so move this >> config to rk3288 own Kconfig >> >> Signed-off-by: Lin Huang <hl@rock-chips.com> >> --- >> Changes in v1: None >> Changes in v2: None >> Changes in v3: None >> >> arch/arm/mach-rockchip/Kconfig | 3 --- >> arch/arm/mach-rockchip/rk3288/Kconfig | 3 +++ >> 2 files changed, 3 insertions(+), 3 deletions(-) > I thought I Acked this patch, and several others. To avoid me having > to review everything again, can you please pick those up and send a > new version? i checked v1 patch, you Ack several patchs, include: rockchip: Bring in RK3036 device tree file includes and bindings rockchip: rk3036: Add clock driver rockchip: rk3036: Add header files for GRF rockchip: rk3036: Add Soc reset driver rockchip: rk3036: Add a simple syscon driver rockchip: rk3036: Add pinctrl driver but since we add the SPL stage, it is a big move, so these patchs all have been modified, and need your help to review again, > Regards, > Simon > > >
Hi Lin, On 8 November 2015 at 18:59, hl <hl@rock-chips.com> wrote: > Hi Simon, > > On 06/11/15 20:08, Simon Glass wrote: >> >> Hi, >> >> On 6 November 2015 at 01:33, Lin Huang <hl@rock-chips.com> wrote: >>> >>> since different rockchip SOC have different size of SRAM, >>> So the size SYS_MALLOC_F_LEN may different, so move this >>> config to rk3288 own Kconfig >>> >>> Signed-off-by: Lin Huang <hl@rock-chips.com> >>> --- >>> Changes in v1: None >>> Changes in v2: None >>> Changes in v3: None >>> >>> arch/arm/mach-rockchip/Kconfig | 3 --- >>> arch/arm/mach-rockchip/rk3288/Kconfig | 3 +++ >>> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> I thought I Acked this patch, and several others. To avoid me having >> to review everything again, can you please pick those up and send a >> new version? > > i checked v1 patch, you Ack several patchs, include: > rockchip: Bring in RK3036 device tree file includes and bindings > rockchip: rk3036: Add clock driver > rockchip: rk3036: Add header files for GRF > rockchip: rk3036: Add Soc reset driver > rockchip: rk3036: Add a simple syscon driver > rockchip: rk3036: Add pinctrl driver > but since we add the SPL stage, it is a big move, so these patchs all > have been modified, > and need your help to review again, OK - do you want me to do another pass now, or do you want to send a new version first? Regards, Simon
Hi Simon, On 09/11/15 12:46, Simon Glass wrote: > Hi Lin, > > On 8 November 2015 at 18:59, hl <hl@rock-chips.com> wrote: >> Hi Simon, >> >> On 06/11/15 20:08, Simon Glass wrote: >>> Hi, >>> >>> On 6 November 2015 at 01:33, Lin Huang <hl@rock-chips.com> wrote: >>>> since different rockchip SOC have different size of SRAM, >>>> So the size SYS_MALLOC_F_LEN may different, so move this >>>> config to rk3288 own Kconfig >>>> >>>> Signed-off-by: Lin Huang <hl@rock-chips.com> >>>> --- >>>> Changes in v1: None >>>> Changes in v2: None >>>> Changes in v3: None >>>> >>>> arch/arm/mach-rockchip/Kconfig | 3 --- >>>> arch/arm/mach-rockchip/rk3288/Kconfig | 3 +++ >>>> 2 files changed, 3 insertions(+), 3 deletions(-) >>> I thought I Acked this patch, and several others. To avoid me having >>> to review everything again, can you please pick those up and send a >>> new version? >> i checked v1 patch, you Ack several patchs, include: >> rockchip: Bring in RK3036 device tree file includes and bindings >> rockchip: rk3036: Add clock driver >> rockchip: rk3036: Add header files for GRF >> rockchip: rk3036: Add Soc reset driver >> rockchip: rk3036: Add a simple syscon driver >> rockchip: rk3036: Add pinctrl driver >> but since we add the SPL stage, it is a big move, so these patchs all >> have been modified, >> and need your help to review again, > OK - do you want me to do another pass now, or do you want to send a > new version first? I think i will send a new version later today first, and you can help to review in the new verion patch, thank you. > > Regards, > Simon > > >
diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig index ab50f4e..da665ef 100644 --- a/arch/arm/mach-rockchip/Kconfig +++ b/arch/arm/mach-rockchip/Kconfig @@ -12,9 +12,6 @@ config ROCKCHIP_RK3288 config SYS_MALLOC_F default y -config SYS_MALLOC_F_LEN - default 0x800 - config SPL_DM default y diff --git a/arch/arm/mach-rockchip/rk3288/Kconfig b/arch/arm/mach-rockchip/rk3288/Kconfig index 4d0f1b5..d0a7276 100644 --- a/arch/arm/mach-rockchip/rk3288/Kconfig +++ b/arch/arm/mach-rockchip/rk3288/Kconfig @@ -19,6 +19,9 @@ config TARGET_CHROMEBOOK_JERRY config SYS_SOC default "rockchip" +config SYS_MALLOC_F_LEN + default 0x0800 + source "board/google/chromebook_jerry/Kconfig" source "board/firefly/firefly-rk3288/Kconfig"
since different rockchip SOC have different size of SRAM, So the size SYS_MALLOC_F_LEN may different, so move this config to rk3288 own Kconfig Signed-off-by: Lin Huang <hl@rock-chips.com> --- Changes in v1: None Changes in v2: None Changes in v3: None arch/arm/mach-rockchip/Kconfig | 3 --- arch/arm/mach-rockchip/rk3288/Kconfig | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-)