| Message ID | 20100527055100.GA21234@hera.kernel.org |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Denis Kirjanov <dkirjanov@hera.kernel.org> Date: Thu, 27 May 2010 05:51:00 +0000 > Add RTNL assertion to linkwatch_run_queue since function > must be called with semaphore held > > Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org> This function is exported purely for netdev_wait_allrefs()'s sake and for no other purpose. In fact, I'd say this is entirely a private functional interface specifically built for generic network interface tear-down. If you are trying to use this function in another context, that's something you need to discuss with us first before we start peppering it with various assertions. I am not applying this patch. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/link_watch.c b/net/core/link_watch.c index bdbce2f..e6d06c0 100644 --- a/net/core/link_watch.c +++ b/net/core/link_watch.c @@ -220,6 +220,7 @@ void linkwatch_forget_dev(struct net_device *dev) /* Must be called with the rtnl semaphore held */ void linkwatch_run_queue(void) { + ASSERT_RTNL(); __linkwatch_run_queue(0); }
Add RTNL assertion to linkwatch_run_queue since function must be called with semaphore held Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org> --- net/core/link_watch.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html