From patchwork Thu May 27 05:51:00 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Denis Kirjanov X-Patchwork-Id: 53681 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 447FEB7D27 for ; Thu, 27 May 2010 15:51:18 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752061Ab0E0FvN (ORCPT ); Thu, 27 May 2010 01:51:13 -0400 Received: from hera.kernel.org ([140.211.167.34]:50035 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751421Ab0E0FvM (ORCPT ); Thu, 27 May 2010 01:51:12 -0400 Received: from hera.kernel.org (localhost [127.0.0.1]) by hera.kernel.org (8.14.3/8.14.3) with ESMTP id o4R5p1Kn026746 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 27 May 2010 05:51:01 GMT X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.95.2 at hera.kernel.org Received: (from dkirjanov@localhost) by hera.kernel.org (8.14.3/8.14.2/Submit) id o4R5p03f026678; Thu, 27 May 2010 05:51:00 GMT Date: Thu, 27 May 2010 05:51:00 +0000 From: Denis Kirjanov To: davem@davemloft.net Cc: eric.dumazet@gmail.com, shemminger@vyatta.com, herbert@gondor.hengli.com.au, kaber@trash.net, netdev@vger.kernel.org Subject: [PATCH] net: add rtnl assertion to linkwatch_run_queue Message-ID: <20100527055100.GA21234@hera.kernel.org> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.19 (2009-01-05) X-Spam-Status: No, score=0.4 required=5.0 tests=ALL_TRUSTED,BAYES_00, DATE_IN_FUTURE_96_Q autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on hera.kernel.org X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.3 (hera.kernel.org [127.0.0.1]); Thu, 27 May 2010 05:51:01 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Add RTNL assertion to linkwatch_run_queue since function must be called with semaphore held Signed-off-by: Denis Kirjanov --- net/core/link_watch.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/core/link_watch.c b/net/core/link_watch.c index bdbce2f..e6d06c0 100644 --- a/net/core/link_watch.c +++ b/net/core/link_watch.c @@ -220,6 +220,7 @@ void linkwatch_forget_dev(struct net_device *dev) /* Must be called with the rtnl semaphore held */ void linkwatch_run_queue(void) { + ASSERT_RTNL(); __linkwatch_run_queue(0); }