| Message ID | 1445426953-15934-1-git-send-email-kda@linux-powerpc.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, 2015-21-10 at 11:29:13 UTC, Denis Kirjanov wrote: > Building with CONFIG_DEBUG_SECTION_MISMATCH > gives the following warning: > > WARNING: vmlinux.o(.text+0x41fa8): Section mismatch in reference from > the function .msi_bitmap_alloc() to the function > .init.text:.memblock_virt_alloc_try_nid() > The function .msi_bitmap_alloc() references > the function __init .memblock_virt_alloc_try_nid(). > This is often because .msi_bitmap_alloc lacks a __init > annotation or the annotation of .memblock_virt_alloc_try_nid is wrong. > > memory allocation in msi_bitmap_alloc use either slab allocator or > memblock boot-time allocator so that's why we need the __init_refok > for the latter case. > > Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/ccde64b51b33821159d52b09 cheers
diff --git a/arch/powerpc/sysdev/msi_bitmap.c b/arch/powerpc/sysdev/msi_bitmap.c index 1a826f3..ed5234e 100644 --- a/arch/powerpc/sysdev/msi_bitmap.c +++ b/arch/powerpc/sysdev/msi_bitmap.c @@ -112,7 +112,7 @@ int msi_bitmap_reserve_dt_hwirqs(struct msi_bitmap *bmp) return 0; } -int msi_bitmap_alloc(struct msi_bitmap *bmp, unsigned int irq_count, +int __init_refok msi_bitmap_alloc(struct msi_bitmap *bmp, unsigned int irq_count, struct device_node *of_node) { int size;
Building with CONFIG_DEBUG_SECTION_MISMATCH gives the following warning: WARNING: vmlinux.o(.text+0x41fa8): Section mismatch in reference from the function .msi_bitmap_alloc() to the function .init.text:.memblock_virt_alloc_try_nid() The function .msi_bitmap_alloc() references the function __init .memblock_virt_alloc_try_nid(). This is often because .msi_bitmap_alloc lacks a __init annotation or the annotation of .memblock_virt_alloc_try_nid is wrong. memory allocation in msi_bitmap_alloc use either slab allocator or memblock boot-time allocator so that's why we need the __init_refok for the latter case. Signed-off-by: Denis Kirjanov <kda@linux-powerpc.org> --- arch/powerpc/sysdev/msi_bitmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)