| Message ID | 1443611693-23722-5-git-send-email-p.marczak@samsung.com |
|---|---|
| State | Accepted |
| Delegated to: | Simon Glass |
| Headers | show |
Hi, Przemyslaw. On 09/30/2015 08:14 PM, Przemyslaw Marczak wrote: > This device uses SDHCI driver, for eMMC and SD cards. > Trying bind the DW MMC driver with fdt node without all > required properties, causes printing an error. > > This commit disables the DW MMC node. Why does it need? Trats board doesn't support the Designware IP, so i think right that it shouldn't build. If needs to modify, exynos-common.h should be modified. > > Tested-on: Trats > > Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com> > Cc: Łukasz Majewski <l.majewski@samsung.com> > Cc: Minkyu Kang <mk7.kang@samsung.com> > -- > Changes V3: > - new commit > --- > arch/arm/dts/exynos4210-trats.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/dts/exynos4210-trats.dts b/arch/arm/dts/exynos4210-trats.dts > index 36d02df..f3fac80 100644 > --- a/arch/arm/dts/exynos4210-trats.dts > +++ b/arch/arm/dts/exynos4210-trats.dts > @@ -117,4 +117,8 @@ > sdhci@12540000 { > status = "disabled"; > }; > + > + dwmmc@12550000 { > + status = "disabled"; > + }; It seems to support dwmmc controller. 12550000 addr is for sdhci controller. Best Regards, Jaehoon Chung > }; >
Hello Jaehoon, On 10/01/2015 05:37 AM, Jaehoon Chung wrote: > Hi, Przemyslaw. > > On 09/30/2015 08:14 PM, Przemyslaw Marczak wrote: >> This device uses SDHCI driver, for eMMC and SD cards. >> Trying bind the DW MMC driver with fdt node without all >> required properties, causes printing an error. >> >> This commit disables the DW MMC node. > > Why does it need? > Trats board doesn't support the Designware IP, so i think right that it shouldn't build. > > If needs to modify, exynos-common.h should be modified. > I think, that some day, we will have a single config, for at least exynos5 and exynos4 (if doesn't exceed the size limit), so using the generic configuration is reasonable here. Trats is based on Exynos4210, which supports this IP, and I checked the documentation, the address 0x12550000 is proper - Mobile Storage Host. For a long time it wasn't enable on this device, and only printed an error, that 'bus-width' not found. I tried to enable this, but it doesn't work for the same settings as for Trats2. Now I don't have time to debug why, so it can be disabled. >> >> Tested-on: Trats >> >> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com> >> Cc: Łukasz Majewski <l.majewski@samsung.com> >> Cc: Minkyu Kang <mk7.kang@samsung.com> >> -- >> Changes V3: >> - new commit >> --- >> arch/arm/dts/exynos4210-trats.dts | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/dts/exynos4210-trats.dts b/arch/arm/dts/exynos4210-trats.dts >> index 36d02df..f3fac80 100644 >> --- a/arch/arm/dts/exynos4210-trats.dts >> +++ b/arch/arm/dts/exynos4210-trats.dts >> @@ -117,4 +117,8 @@ >> sdhci@12540000 { >> status = "disabled"; >> }; >> + >> + dwmmc@12550000 { >> + status = "disabled"; >> + }; > > It seems to support dwmmc controller. 12550000 addr is for sdhci controller. Please check manual for E4210, I'm sure it's right. > > Best Regards, > Jaehoon Chung > >> }; >> > > Best regards,
Hi, On 10/01/2015 04:11 PM, Przemyslaw Marczak wrote: > Hello Jaehoon, > > On 10/01/2015 05:37 AM, Jaehoon Chung wrote: >> Hi, Przemyslaw. >> >> On 09/30/2015 08:14 PM, Przemyslaw Marczak wrote: >>> This device uses SDHCI driver, for eMMC and SD cards. >>> Trying bind the DW MMC driver with fdt node without all >>> required properties, causes printing an error. >>> >>> This commit disables the DW MMC node. >> >> Why does it need? >> Trats board doesn't support the Designware IP, so i think right that it shouldn't build. >> >> If needs to modify, exynos-common.h should be modified. >> > > I think, that some day, we will have a single config, for at least exynos5 and exynos4 (if doesn't exceed the size limit), so using the generic configuration is reasonable here. Single config? Well, if do so, it will be great..not yet. > > Trats is based on Exynos4210, which supports this IP, and I checked the documentation, the address 0x12550000 is proper - Mobile Storage Host. Sorry..I have confused with C110. :) Best Regards, Jaehoon Chung > > For a long time it wasn't enable on this device, and only printed an error, that 'bus-width' not found. I tried to enable this, but it doesn't work for the same settings as for Trats2. Now I don't have time to debug why, so it can be disabled. > >>> >>> Tested-on: Trats >>> >>> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com> >>> Cc: Łukasz Majewski <l.majewski@samsung.com> >>> Cc: Minkyu Kang <mk7.kang@samsung.com> >>> -- >>> Changes V3: >>> - new commit >>> --- >>> arch/arm/dts/exynos4210-trats.dts | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/arch/arm/dts/exynos4210-trats.dts b/arch/arm/dts/exynos4210-trats.dts >>> index 36d02df..f3fac80 100644 >>> --- a/arch/arm/dts/exynos4210-trats.dts >>> +++ b/arch/arm/dts/exynos4210-trats.dts >>> @@ -117,4 +117,8 @@ >>> sdhci@12540000 { >>> status = "disabled"; >>> }; >>> + >>> + dwmmc@12550000 { >>> + status = "disabled"; >>> + }; >> >> It seems to support dwmmc controller. 12550000 addr is for sdhci controller. > > Please check manual for E4210, I'm sure it's right. > >> >> Best Regards, >> Jaehoon Chung >> >>> }; >>> >> >> > > Best regards,
On 1 October 2015 at 08:22, Jaehoon Chung <jh80.chung@samsung.com> wrote: > Hi, > > On 10/01/2015 04:11 PM, Przemyslaw Marczak wrote: >> Hello Jaehoon, >> >> On 10/01/2015 05:37 AM, Jaehoon Chung wrote: >>> Hi, Przemyslaw. >>> >>> On 09/30/2015 08:14 PM, Przemyslaw Marczak wrote: >>>> This device uses SDHCI driver, for eMMC and SD cards. >>>> Trying bind the DW MMC driver with fdt node without all >>>> required properties, causes printing an error. >>>> >>>> This commit disables the DW MMC node. >>> >>> Why does it need? >>> Trats board doesn't support the Designware IP, so i think right that it shouldn't build. >>> >>> If needs to modify, exynos-common.h should be modified. >>> >> >> I think, that some day, we will have a single config, for at least exynos5 and exynos4 (if doesn't exceed the size limit), so using the generic configuration is reasonable here. > > Single config? Well, if do so, it will be great..not yet. > >> >> Trats is based on Exynos4210, which supports this IP, and I checked the documentation, the address 0x12550000 is proper - Mobile Storage Host. > > Sorry..I have confused with C110. :) > > Best Regards, > Jaehoon Chung Applied to u-boot-fdt, thanks!
diff --git a/arch/arm/dts/exynos4210-trats.dts b/arch/arm/dts/exynos4210-trats.dts index 36d02df..f3fac80 100644 --- a/arch/arm/dts/exynos4210-trats.dts +++ b/arch/arm/dts/exynos4210-trats.dts @@ -117,4 +117,8 @@ sdhci@12540000 { status = "disabled"; }; + + dwmmc@12550000 { + status = "disabled"; + }; };
This device uses SDHCI driver, for eMMC and SD cards. Trying bind the DW MMC driver with fdt node without all required properties, causes printing an error. This commit disables the DW MMC node. Tested-on: Trats Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com> Cc: Łukasz Majewski <l.majewski@samsung.com> Cc: Minkyu Kang <mk7.kang@samsung.com> -- Changes V3: - new commit --- arch/arm/dts/exynos4210-trats.dts | 4 ++++ 1 file changed, 4 insertions(+)