| Message ID | 1443545373-9115-1-git-send-email-Vincent.Riera@imgtec.com |
|---|---|
| State | Superseded |
| Headers | show |
Hi Vincent, On Tue, Sep 29, 2015 at 05:49:33PM +0100, Vicente Olivert Riera wrote: > There are some missing dependencies which are in fact stated in the > comment, and due to that you can select the package despite of not > satisfying them. > Also propagate the !STATIC dependency from mesa3d and add some comments. > > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> > --- > package/glmark2/Config.in | 12 +++++++++--- > 1 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/package/glmark2/Config.in b/package/glmark2/Config.in > index 052e820..6ab4f5b 100644 > --- a/package/glmark2/Config.in > +++ b/package/glmark2/Config.in > @@ -15,6 +15,12 @@ comment "glmark2 needs an OpenGL or an openGL ES and EGL backend provided by mes > config BR2_PACKAGE_GLMARK2 > bool "glmark2" > depends on BR2_PACKAGE_GLMARK2_GL || BR2_PACKAGE_GLMARK2_EGL_GLES > + # glmark2-gl and glmark2-egl-gles depend on mesa3d, which intruduces > + # dependencies on NPTL, STDCPP and !STATIC. > + depends on BR2_INSTALL_LIBSTDCPP # mesa3d > + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # mesa3d > + depends on !BR2_STATIC_LIBS # mesa3d > + depends on BR2_PACKAGE_HAS_UDEV Why would that be needed? Kconfig 'depends' is transitive. That is, since glmark2 depends on glmark2-gl/glmark2-egl-gles, that in turn depend on mesa3d, glmark2 automatically also depends on mesa3d dependencies. It is only for 'select' that we need to manually propagate dependencies. Did you hit any specific problem? baruch > select BR2_PACKAGE_JPEG > select BR2_PACKAGE_LIBPNG > help > @@ -22,6 +28,6 @@ config BR2_PACKAGE_GLMARK2 > > https://github.com/glmark2/glmark2 > > -comment "glmark2 needs udev /dev management and a toolchain w/ C++, NPTL" > - depends on !BR2_INSTALL_LIBSTDCPP || \ > - !BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_PACKAGE_HAS_UDEV > +comment "glmark2 needs udev and a toolchain w/ C++, NPTL, shared library" > + depends on !BR2_PACKAGE_HAS_UDEV || !BR2_INSTALL_LIBSTDCPP || \ > + !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
Hello Baruch, On 29/09/15 18:01, Baruch Siach wrote: > Hi Vincent, > > On Tue, Sep 29, 2015 at 05:49:33PM +0100, Vicente Olivert Riera wrote: >> There are some missing dependencies which are in fact stated in the >> comment, and due to that you can select the package despite of not >> satisfying them. >> Also propagate the !STATIC dependency from mesa3d and add some comments. >> >> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> >> --- >> package/glmark2/Config.in | 12 +++++++++--- >> 1 files changed, 9 insertions(+), 3 deletions(-) >> >> diff --git a/package/glmark2/Config.in b/package/glmark2/Config.in >> index 052e820..6ab4f5b 100644 >> --- a/package/glmark2/Config.in >> +++ b/package/glmark2/Config.in >> @@ -15,6 +15,12 @@ comment "glmark2 needs an OpenGL or an openGL ES and EGL backend provided by mes >> config BR2_PACKAGE_GLMARK2 >> bool "glmark2" >> depends on BR2_PACKAGE_GLMARK2_GL || BR2_PACKAGE_GLMARK2_EGL_GLES >> + # glmark2-gl and glmark2-egl-gles depend on mesa3d, which intruduces >> + # dependencies on NPTL, STDCPP and !STATIC. >> + depends on BR2_INSTALL_LIBSTDCPP # mesa3d >> + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # mesa3d >> + depends on !BR2_STATIC_LIBS # mesa3d >> + depends on BR2_PACKAGE_HAS_UDEV > > Why would that be needed? Kconfig 'depends' is transitive. That is, since > glmark2 depends on glmark2-gl/glmark2-egl-gles, that in turn depend on mesa3d, > glmark2 automatically also depends on mesa3d dependencies. It is only for > 'select' that we need to manually propagate dependencies. > > Did you hit any specific problem? Yes, you can satisfy this dependency... depends on BR2_PACKAGE_GLMARK2_GL || BR2_PACKAGE_GLMARK2_EGL_GLES ...and be able to select the glmark2 package from the menu despite of not satisfying the BR2_PACKAGE_HAS_UDEV dependency. In fact, you will still see the comment on the menu, but the comment about the opengl stuff will be replaced by the package so you can select it. Regards, Vincent. > > baruch > >> select BR2_PACKAGE_JPEG >> select BR2_PACKAGE_LIBPNG >> help >> @@ -22,6 +28,6 @@ config BR2_PACKAGE_GLMARK2 >> >> https://github.com/glmark2/glmark2 >> >> -comment "glmark2 needs udev /dev management and a toolchain w/ C++, NPTL" >> - depends on !BR2_INSTALL_LIBSTDCPP || \ >> - !BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_PACKAGE_HAS_UDEV >> +comment "glmark2 needs udev and a toolchain w/ C++, NPTL, shared library" >> + depends on !BR2_PACKAGE_HAS_UDEV || !BR2_INSTALL_LIBSTDCPP || \ >> + !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS >
On 30-09-15 09:50, Vicente Olivert Riera wrote: > Hello Baruch, > > On 29/09/15 18:01, Baruch Siach wrote: >> Hi Vincent, >> >> On Tue, Sep 29, 2015 at 05:49:33PM +0100, Vicente Olivert Riera wrote: >>> There are some missing dependencies which are in fact stated in the >>> comment, and due to that you can select the package despite of not >>> satisfying them. >>> Also propagate the !STATIC dependency from mesa3d and add some comments. >>> >>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> >>> --- >>> package/glmark2/Config.in | 12 +++++++++--- >>> 1 files changed, 9 insertions(+), 3 deletions(-) >>> >>> diff --git a/package/glmark2/Config.in b/package/glmark2/Config.in >>> index 052e820..6ab4f5b 100644 >>> --- a/package/glmark2/Config.in >>> +++ b/package/glmark2/Config.in >>> @@ -15,6 +15,12 @@ comment "glmark2 needs an OpenGL or an openGL ES and EGL >>> backend provided by mes >>> config BR2_PACKAGE_GLMARK2 >>> bool "glmark2" >>> depends on BR2_PACKAGE_GLMARK2_GL || BR2_PACKAGE_GLMARK2_EGL_GLES >>> + # glmark2-gl and glmark2-egl-gles depend on mesa3d, which intruduces >>> + # dependencies on NPTL, STDCPP and !STATIC. >>> + depends on BR2_INSTALL_LIBSTDCPP # mesa3d >>> + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # mesa3d >>> + depends on !BR2_STATIC_LIBS # mesa3d >>> + depends on BR2_PACKAGE_HAS_UDEV >> >> Why would that be needed? Kconfig 'depends' is transitive. That is, since >> glmark2 depends on glmark2-gl/glmark2-egl-gles, that in turn depend on mesa3d, >> glmark2 automatically also depends on mesa3d dependencies. It is only for >> 'select' that we need to manually propagate dependencies. >> >> Did you hit any specific problem? > > Yes, you can satisfy this dependency... > > depends on BR2_PACKAGE_GLMARK2_GL || BR2_PACKAGE_GLMARK2_EGL_GLES > > ...and be able to select the glmark2 package from the menu despite of not > satisfying the BR2_PACKAGE_HAS_UDEV dependency. In fact, you will still see the > comment on the menu, but the comment about the opengl stuff will be replaced by > the package so you can select it. The UDEV part of the comment is in fact wrong. UDEV dependency was removed from mesa3d in f5fbb12da0f0f1dbf23cdd603f41103da41e4f68, but glmark2 was not updated. Regards, Arnout > > Regards, > > Vincent. > >> >> baruch >> >>> select BR2_PACKAGE_JPEG >>> select BR2_PACKAGE_LIBPNG >>> help >>> @@ -22,6 +28,6 @@ config BR2_PACKAGE_GLMARK2 >>> >>> https://github.com/glmark2/glmark2 >>> >>> -comment "glmark2 needs udev /dev management and a toolchain w/ C++, NPTL" >>> - depends on !BR2_INSTALL_LIBSTDCPP || \ >>> - !BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_PACKAGE_HAS_UDEV >>> +comment "glmark2 needs udev and a toolchain w/ C++, NPTL, shared library" >>> + depends on !BR2_PACKAGE_HAS_UDEV || !BR2_INSTALL_LIBSTDCPP || \ >>> + !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS >> > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot >
diff --git a/package/glmark2/Config.in b/package/glmark2/Config.in index 052e820..6ab4f5b 100644 --- a/package/glmark2/Config.in +++ b/package/glmark2/Config.in @@ -15,6 +15,12 @@ comment "glmark2 needs an OpenGL or an openGL ES and EGL backend provided by mes config BR2_PACKAGE_GLMARK2 bool "glmark2" depends on BR2_PACKAGE_GLMARK2_GL || BR2_PACKAGE_GLMARK2_EGL_GLES + # glmark2-gl and glmark2-egl-gles depend on mesa3d, which intruduces + # dependencies on NPTL, STDCPP and !STATIC. + depends on BR2_INSTALL_LIBSTDCPP # mesa3d + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # mesa3d + depends on !BR2_STATIC_LIBS # mesa3d + depends on BR2_PACKAGE_HAS_UDEV select BR2_PACKAGE_JPEG select BR2_PACKAGE_LIBPNG help @@ -22,6 +28,6 @@ config BR2_PACKAGE_GLMARK2 https://github.com/glmark2/glmark2 -comment "glmark2 needs udev /dev management and a toolchain w/ C++, NPTL" - depends on !BR2_INSTALL_LIBSTDCPP || \ - !BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_PACKAGE_HAS_UDEV +comment "glmark2 needs udev and a toolchain w/ C++, NPTL, shared library" + depends on !BR2_PACKAGE_HAS_UDEV || !BR2_INSTALL_LIBSTDCPP || \ + !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
There are some missing dependencies which are in fact stated in the comment, and due to that you can select the package despite of not satisfying them. Also propagate the !STATIC dependency from mesa3d and add some comments. Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> --- package/glmark2/Config.in | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-)