| Message ID | 1443201500-9256-4-git-send-email-tjakobi@math.uni-bielefeld.de |
|---|---|
| State | Changes Requested |
| Delegated to: | Minkyu Kang |
| Headers | show |
Hello, On 09/25/2015 07:18 PM, Tobias Jakobi wrote: > Add more debug printfs in do_sdhci_init() for calls > that can potentially fail. > > Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de> > --- > drivers/mmc/s5p_sdhci.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c > index b60bc23..f88d76b 100644 > --- a/drivers/mmc/s5p_sdhci.c > +++ b/drivers/mmc/s5p_sdhci.c > @@ -102,29 +102,31 @@ struct sdhci_host sdhci_host[SDHCI_MAX_HOSTS]; > > static int do_sdhci_init(struct sdhci_host *host) > { > - int dev_id, flag; > - int err = 0; > + int dev_id, flag, ret; > > flag = host->bus_width == 8 ? PINMUX_FLAG_8BIT_MODE : PINMUX_FLAG_NONE; > dev_id = host->index + PERIPH_ID_SDMMC0; > > if (dm_gpio_is_valid(&host->pwr_gpio)) { > dm_gpio_set_value(&host->pwr_gpio, 1); > - err = exynos_pinmux_config(dev_id, flag); > - if (err) { > + ret = exynos_pinmux_config(dev_id, flag); > + if (ret) { > debug("MMC not configured\n"); > - return err; > + return ret; > } > } > > if (dm_gpio_is_valid(&host->cd_gpio)) { > - if (dm_gpio_get_value(&host->cd_gpio)) > + ret = dm_gpio_get_value(&host->cd_gpio); > + if (ret) { > + debug("no SD card detected (%d)\n", ret); > return -ENODEV; > + } > > - err = exynos_pinmux_config(dev_id, flag); > - if (err) { > + ret = exynos_pinmux_config(dev_id, flag); > + if (ret) { > printf("external SD not configured\n"); > - return err; > + return ret; > } > } > > Acked-by: Przemyslaw Marczak <p.marczak@samsung.com> Best regards,
diff --git a/drivers/mmc/s5p_sdhci.c b/drivers/mmc/s5p_sdhci.c index b60bc23..f88d76b 100644 --- a/drivers/mmc/s5p_sdhci.c +++ b/drivers/mmc/s5p_sdhci.c @@ -102,29 +102,31 @@ struct sdhci_host sdhci_host[SDHCI_MAX_HOSTS]; static int do_sdhci_init(struct sdhci_host *host) { - int dev_id, flag; - int err = 0; + int dev_id, flag, ret; flag = host->bus_width == 8 ? PINMUX_FLAG_8BIT_MODE : PINMUX_FLAG_NONE; dev_id = host->index + PERIPH_ID_SDMMC0; if (dm_gpio_is_valid(&host->pwr_gpio)) { dm_gpio_set_value(&host->pwr_gpio, 1); - err = exynos_pinmux_config(dev_id, flag); - if (err) { + ret = exynos_pinmux_config(dev_id, flag); + if (ret) { debug("MMC not configured\n"); - return err; + return ret; } } if (dm_gpio_is_valid(&host->cd_gpio)) { - if (dm_gpio_get_value(&host->cd_gpio)) + ret = dm_gpio_get_value(&host->cd_gpio); + if (ret) { + debug("no SD card detected (%d)\n", ret); return -ENODEV; + } - err = exynos_pinmux_config(dev_id, flag); - if (err) { + ret = exynos_pinmux_config(dev_id, flag); + if (ret) { printf("external SD not configured\n"); - return err; + return ret; } }
Add more debug printfs in do_sdhci_init() for calls that can potentially fail. Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de> --- drivers/mmc/s5p_sdhci.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-)