diff mbox

[U-Boot,V2,03/11] Peach-Pi: dts: add cpu-model string

Message ID 1442838403-27777-4-git-send-email-p.marczak@samsung.com
State Changes Requested
Delegated to: Minkyu Kang
Headers show

Commit Message

Przemyslaw Marczak Sept. 21, 2015, 12:26 p.m. UTC
This platform is based on Exynos5800 but the cpu id is 0x5422.
This doesn't fit the common Exynos SoC name convention, so now,
the CPU name is defined by device tree string, to be printed
properly.

Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
---
Changes V2:
- move cpu name from config to dts
---
 arch/arm/dts/exynos5800-peach-pi.dts | 1 +
 1 file changed, 1 insertion(+)

Comments

Simon Glass Oct. 3, 2015, 2:28 p.m. UTC | #1
Hi Przemyslaw,

On 21 September 2015 at 13:26, Przemyslaw Marczak <p.marczak@samsung.com> wrote:
> This platform is based on Exynos5800 but the cpu id is 0x5422.
> This doesn't fit the common Exynos SoC name convention, so now,
> the CPU name is defined by device tree string, to be printed
> properly.
>
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> ---
> Changes V2:
> - move cpu name from config to dts
> ---
>  arch/arm/dts/exynos5800-peach-pi.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/dts/exynos5800-peach-pi.dts b/arch/arm/dts/exynos5800-peach-pi.dts
> index 1d7ff23..76826dc 100644
> --- a/arch/arm/dts/exynos5800-peach-pi.dts
> +++ b/arch/arm/dts/exynos5800-peach-pi.dts
> @@ -12,6 +12,7 @@
>
>  / {
>         model = "Samsung/Google Peach Pi board based on Exynos5800";
> +       cpu-model = "Exynos5800";
>
>         compatible = "google,pit-rev#", "google,pit",
>                 "google,peach", "samsung,exynos5800", "samsung,exynos5";
> --
> 1.9.1
>

Is this defined by the standard binding? If not, can you add or change
the binding file?

Regards,
Simon
Przemyslaw Marczak Oct. 13, 2015, 11:57 a.m. UTC | #2
Hello Simon,

On 10/03/2015 04:28 PM, Simon Glass wrote:
> Hi Przemyslaw,
>
> On 21 September 2015 at 13:26, Przemyslaw Marczak <p.marczak@samsung.com> wrote:
>> This platform is based on Exynos5800 but the cpu id is 0x5422.
>> This doesn't fit the common Exynos SoC name convention, so now,
>> the CPU name is defined by device tree string, to be printed
>> properly.
>>
>> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
>> ---
>> Changes V2:
>> - move cpu name from config to dts
>> ---
>>   arch/arm/dts/exynos5800-peach-pi.dts | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/dts/exynos5800-peach-pi.dts b/arch/arm/dts/exynos5800-peach-pi.dts
>> index 1d7ff23..76826dc 100644
>> --- a/arch/arm/dts/exynos5800-peach-pi.dts
>> +++ b/arch/arm/dts/exynos5800-peach-pi.dts
>> @@ -12,6 +12,7 @@
>>
>>   / {
>>          model = "Samsung/Google Peach Pi board based on Exynos5800";
>> +       cpu-model = "Exynos5800";
>>
>>          compatible = "google,pit-rev#", "google,pit",
>>                  "google,peach", "samsung,exynos5800", "samsung,exynos5";
>> --
>> 1.9.1
>>
>
> Is this defined by the standard binding? If not, can you add or change
> the binding file?
>
> Regards,
> Simon
>

No, it's not standard. I will add binding info.

Best regards
diff mbox

Patch

diff --git a/arch/arm/dts/exynos5800-peach-pi.dts b/arch/arm/dts/exynos5800-peach-pi.dts
index 1d7ff23..76826dc 100644
--- a/arch/arm/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/dts/exynos5800-peach-pi.dts
@@ -12,6 +12,7 @@ 
 
 / {
 	model = "Samsung/Google Peach Pi board based on Exynos5800";
+	cpu-model = "Exynos5800";
 
 	compatible = "google,pit-rev#", "google,pit",
 		"google,peach", "samsung,exynos5800", "samsung,exynos5";