diff mbox

[U-Boot,v2,1/2] video, lg4573: make spi bus and cs configurable

Message ID 1440409001-25732-1-git-send-email-hs@denx.de
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Commit Message

Heiko Schocher Aug. 24, 2015, 9:36 a.m. UTC
make the spi bus and the spi chipselect configurable
for the lg4573 driver. Use it on the aristainetos
boards.

Signed-off-by: Heiko Schocher <hs@denx.de>

---

Changes in v2:
- add comments from Stefano Babic
  - move this patch before the 2b aristainetos board support
    and add there the spi bus settings for the display
 - rebased against u-boot-imx
   e1518ebda736a1225c4c2a651e21c446dee3fdb0

 drivers/video/lg4573.c          | 3 ++-
 include/configs/aristainetos2.h | 2 ++
 2 files changed, 4 insertions(+), 1 deletion(-)

Comments

Anatolij Gustschin Aug. 24, 2015, 10:27 a.m. UTC | #1
Hi Heiko,

On Mon, 24 Aug 2015 11:36:39 +0200
Heiko Schocher <hs@denx.de> wrote:

> make the spi bus and the spi chipselect configurable
> for the lg4573 driver. Use it on the aristainetos
> boards.
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>

Acked-by: Anatolij Gustschin <agust@denx.de>
Stefano Babic Aug. 31, 2015, 4:52 p.m. UTC | #2
On 24/08/2015 11:36, Heiko Schocher wrote:
> make the spi bus and the spi chipselect configurable
> for the lg4573 driver. Use it on the aristainetos
> boards.
> 
> Signed-off-by: Heiko Schocher <hs@denx.de>
> 
> ---
> 
> Changes in v2:
> - add comments from Stefano Babic
>   - move this patch before the 2b aristainetos board support
>     and add there the spi bus settings for the display
>  - rebased against u-boot-imx
>    e1518ebda736a1225c4c2a651e21c446dee3fdb0
> 
>  drivers/video/lg4573.c          | 3 ++-
>  include/configs/aristainetos2.h | 2 ++
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/video/lg4573.c b/drivers/video/lg4573.c
> index 43670fc..11fef27 100644
> --- a/drivers/video/lg4573.c
> +++ b/drivers/video/lg4573.c
> @@ -220,7 +220,8 @@ err_claim_bus:
>  static int do_lgset(cmd_tbl_t *cmdtp, int flag, int argc,
>  		       char * const argv[])
>  {
> -	lg4573_spi_startup(0, 0, 10000000, SPI_MODE_0);
> +	lg4573_spi_startup(CONFIG_LG4573_BUS, CONFIG_LG4573_CS, 10000000,
> +			   SPI_MODE_0);
>  	return 0;
>  }
>  
> diff --git a/include/configs/aristainetos2.h b/include/configs/aristainetos2.h
> index faeafe2..dd090c5 100644
> --- a/include/configs/aristainetos2.h
> +++ b/include/configs/aristainetos2.h
> @@ -45,6 +45,8 @@
>  /* Framebuffer */
>  #define CONFIG_SYS_LDB_CLOCK 33246000
>  #define CONFIG_LG4573
> +#define CONFIG_LG4573_BUS 0
> +#define CONFIG_LG4573_CS 0
>  
>  #define CONFIG_CMD_BMP
>  
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/drivers/video/lg4573.c b/drivers/video/lg4573.c
index 43670fc..11fef27 100644
--- a/drivers/video/lg4573.c
+++ b/drivers/video/lg4573.c
@@ -220,7 +220,8 @@  err_claim_bus:
 static int do_lgset(cmd_tbl_t *cmdtp, int flag, int argc,
 		       char * const argv[])
 {
-	lg4573_spi_startup(0, 0, 10000000, SPI_MODE_0);
+	lg4573_spi_startup(CONFIG_LG4573_BUS, CONFIG_LG4573_CS, 10000000,
+			   SPI_MODE_0);
 	return 0;
 }
 
diff --git a/include/configs/aristainetos2.h b/include/configs/aristainetos2.h
index faeafe2..dd090c5 100644
--- a/include/configs/aristainetos2.h
+++ b/include/configs/aristainetos2.h
@@ -45,6 +45,8 @@ 
 /* Framebuffer */
 #define CONFIG_SYS_LDB_CLOCK 33246000
 #define CONFIG_LG4573
+#define CONFIG_LG4573_BUS 0
+#define CONFIG_LG4573_CS 0
 
 #define CONFIG_CMD_BMP