| Message ID | 1438273132-20926-6-git-send-email-javier@osg.samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, 2015-30-07 at 16:18:30 UTC, Javier Martinez Canillas wrote: > The I2C core always reports the MODALIAS uevent as "i2c:<client name" > regardless if the driver was matched using the I2C id_table or the > of_match_table. So the driver needs to export the I2C table and this > be built into the module or udev won't have the necessary information > to auto load the correct module when the device is added. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > --- > > drivers/macintosh/therm_windtunnel.c | 1 + > 1 file changed, 1 insertion(+) Who are you expecting to merge this? cheers
Hello Michael, On 08/18/2015 12:24 PM, Michael Ellerman wrote: > On Thu, 2015-30-07 at 16:18:30 UTC, Javier Martinez Canillas wrote: >> The I2C core always reports the MODALIAS uevent as "i2c:<client name" >> regardless if the driver was matched using the I2C id_table or the >> of_match_table. So the driver needs to export the I2C table and this >> be built into the module or udev won't have the necessary information >> to auto load the correct module when the device is added. >> >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> >> --- >> >> drivers/macintosh/therm_windtunnel.c | 1 + >> 1 file changed, 1 insertion(+) > > Who are you expecting to merge this? > I was expecting Benjamin Herrenschmidt since he is listed in MAINTAINERS for drivers/macintosh. I cc'ed him in the patch but now in your answer I don't see him in the cc list, strange. But I'll be happy to re-post if there is another person who is handling the patches for this driver now. BTW there is another patch [0] for the same driver to export the OF id table information, that was not picked either. > cheers > [0]: https://lkml.org/lkml/2015/7/30/503 Best regards,
On Tue, 2015-08-18 at 12:35 +0200, Javier Martinez Canillas wrote: > Hello Michael, > > On 08/18/2015 12:24 PM, Michael Ellerman wrote: > > On Thu, 2015-30-07 at 16:18:30 UTC, Javier Martinez Canillas wrote: > >> The I2C core always reports the MODALIAS uevent as "i2c:<client name" > >> regardless if the driver was matched using the I2C id_table or the > >> of_match_table. So the driver needs to export the I2C table and this > >> be built into the module or udev won't have the necessary information > >> to auto load the correct module when the device is added. > >> > >> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> > >> --- > >> > >> drivers/macintosh/therm_windtunnel.c | 1 + > >> 1 file changed, 1 insertion(+) > > > > Who are you expecting to merge this? > > > > I was expecting Benjamin Herrenschmidt since he is listed in MAINTAINERS > for drivers/macintosh. I cc'ed him in the patch but now in your answer I > don't see him in the cc list, strange. That's the mailing list dropping him from CC because he's subscribed. > But I'll be happy to re-post if there is another person who is handling > the patches for this driver now. > > BTW there is another patch [0] for the same driver to export the OF id > table information, that was not picked either. Yep, I'll grab them both. cheers
Hello Michael, On 08/19/2015 02:51 AM, Michael Ellerman wrote: > On Tue, 2015-08-18 at 12:35 +0200, Javier Martinez Canillas wrote: >> Hello Michael, >> >> On 08/18/2015 12:24 PM, Michael Ellerman wrote: >>> On Thu, 2015-30-07 at 16:18:30 UTC, Javier Martinez Canillas wrote: >>>> The I2C core always reports the MODALIAS uevent as "i2c:<client name" >>>> regardless if the driver was matched using the I2C id_table or the >>>> of_match_table. So the driver needs to export the I2C table and this >>>> be built into the module or udev won't have the necessary information >>>> to auto load the correct module when the device is added. >>>> >>>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> >>>> --- >>>> >>>> drivers/macintosh/therm_windtunnel.c | 1 + >>>> 1 file changed, 1 insertion(+) >>> >>> Who are you expecting to merge this? >>> >> >> I was expecting Benjamin Herrenschmidt since he is listed in MAINTAINERS >> for drivers/macintosh. I cc'ed him in the patch but now in your answer I >> don't see him in the cc list, strange. > > That's the mailing list dropping him from CC because he's subscribed. > >> But I'll be happy to re-post if there is another person who is handling >> the patches for this driver now. >> >> BTW there is another patch [0] for the same driver to export the OF id >> table information, that was not picked either. > > Yep, I'll grab them both. > Perfect, thanks a lot! > cheers > > Best regards,
On Thu, 2015-30-07 at 16:18:30 UTC, Javier Martinez Canillas wrote: > The I2C core always reports the MODALIAS uevent as "i2c:<client name" > regardless if the driver was matched using the I2C id_table or the > of_match_table. So the driver needs to export the I2C table and this > be built into the module or udev won't have the necessary information > to auto load the correct module when the device is added. > > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/cb0eefcc3271ea1d3704 cheers
diff --git a/drivers/macintosh/therm_windtunnel.c b/drivers/macintosh/therm_windtunnel.c index 109dcaa15934..97269567ec01 100644 --- a/drivers/macintosh/therm_windtunnel.c +++ b/drivers/macintosh/therm_windtunnel.c @@ -408,6 +408,7 @@ static const struct i2c_device_id therm_windtunnel_id[] = { { "therm_adm1030", adm1030 }, { } }; +MODULE_DEVICE_TABLE(i2c, therm_windtunnel_id); static int do_probe(struct i2c_client *cl, const struct i2c_device_id *id)
The I2C core always reports the MODALIAS uevent as "i2c:<client name" regardless if the driver was matched using the I2C id_table or the of_match_table. So the driver needs to export the I2C table and this be built into the module or udev won't have the necessary information to auto load the correct module when the device is added. Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com> --- drivers/macintosh/therm_windtunnel.c | 1 + 1 file changed, 1 insertion(+)