| Message ID | 1437945391-27823-1-git-send-email-vz@mleia.com |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Jul 27, 2015 at 12:16:31AM +0300, Vladimir Zapolskiy wrote: > The change removes redundant sysfs binary file boundary checks, > since this task is already done on caller side in fs/sysfs/file.c > > Note, on file size overflow read() now returns 0, and this is a > correct and expected EOF notification according to POSIX. > > Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> Applied to for-current, thanks!
diff --git a/drivers/i2c/i2c-slave-eeprom.c b/drivers/i2c/i2c-slave-eeprom.c index 8223746..1da4496 100644 --- a/drivers/i2c/i2c-slave-eeprom.c +++ b/drivers/i2c/i2c-slave-eeprom.c @@ -80,9 +80,6 @@ static ssize_t i2c_slave_eeprom_bin_read(struct file *filp, struct kobject *kobj struct eeprom_data *eeprom; unsigned long flags; - if (off + count > attr->size) - return -EFBIG; - eeprom = dev_get_drvdata(container_of(kobj, struct device, kobj)); spin_lock_irqsave(&eeprom->buffer_lock, flags); @@ -98,9 +95,6 @@ static ssize_t i2c_slave_eeprom_bin_write(struct file *filp, struct kobject *kob struct eeprom_data *eeprom; unsigned long flags; - if (off + count > attr->size) - return -EFBIG; - eeprom = dev_get_drvdata(container_of(kobj, struct device, kobj)); spin_lock_irqsave(&eeprom->buffer_lock, flags);
The change removes redundant sysfs binary file boundary checks, since this task is already done on caller side in fs/sysfs/file.c Note, on file size overflow read() now returns 0, and this is a correct and expected EOF notification according to POSIX. Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> --- drivers/i2c/i2c-slave-eeprom.c | 6 ------ 1 file changed, 6 deletions(-)