diff mbox

[U-Boot,29/55] dm: power: Don't return an error when regulators are not autoset

Message ID 1435882592-487-30-git-send-email-sjg@chromium.org
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Simon Glass July 3, 2015, 12:16 a.m. UTC 
Not all regulators can be set up automatically. Adjust the code so that
regulators_enable_boot_on() will return success when some are skipped.
Only genuine errors are reported.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 drivers/power/regulator/regulator-uclass.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Przemyslaw Marczak July 10, 2015, 11:54 a.m. UTC | #1 
Hello Simon,

On 07/03/2015 02:16 AM, Simon Glass wrote:
> Not all regulators can be set up automatically. Adjust the code so that
> regulators_enable_boot_on() will return success when some are skipped.
> Only genuine errors are reported.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>   drivers/power/regulator/regulator-uclass.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/regulator/regulator-uclass.c b/drivers/power/regulator/regulator-uclass.c
> index 12e141b..f3fe7a5 100644
> --- a/drivers/power/regulator/regulator-uclass.c
> +++ b/drivers/power/regulator/regulator-uclass.c
> @@ -319,8 +319,10 @@ int regulators_enable_boot_on(bool verbose)
>   	     dev && !ret;
>   	     uclass_next_device(&dev)) {
>   		ret = regulator_autoset(dev);
> -		if (ret == -EMEDIUMTYPE)
> +		if (ret == -EMEDIUMTYPE) {
> +			ret = 0;
>   			continue;
> +		}
>   		if (verbose)
>   			regulator_show(dev, ret);
>   	}
>

Acked-by: Przemyslaw Marczak <p.marczak@samsung.com>

Regards.
Simon Glass July 27, 2015, 11:30 p.m. UTC | #2 
Applied to u-boot-dm.
diff mbox

Patch

diff --git a/drivers/power/regulator/regulator-uclass.c b/drivers/power/regulator/regulator-uclass.c
index 12e141b..f3fe7a5 100644
--- a/drivers/power/regulator/regulator-uclass.c
+++ b/drivers/power/regulator/regulator-uclass.c
@@ -319,8 +319,10 @@  int regulators_enable_boot_on(bool verbose)
 	     dev && !ret;
 	     uclass_next_device(&dev)) {
 		ret = regulator_autoset(dev);
-		if (ret == -EMEDIUMTYPE)
+		if (ret == -EMEDIUMTYPE) {
+			ret = 0;
 			continue;
+		}
 		if (verbose)
 			regulator_show(dev, ret);
 	}