Patchwork [5/7] arch/powerpc/kernel: Use set_cpus_allowed_ptr

login
register
mail settings
Submitter Julia Lawall
Date March 26, 2010, 10:03 p.m.
Message ID <Pine.LNX.4.64.1003262303080.6480@ask.diku.dk>
Download mbox | patch
Permalink /patch/48729/
State Accepted
Commit 21dbeb91a24d867af0e98ba155bfa80d2906344f
Delegated to: Benjamin Herrenschmidt
Headers show

Comments

Julia Lawall - March 26, 2010, 10:03 p.m.
From: Julia Lawall <julia@diku.dk>

Use set_cpus_allowed_ptr rather than set_cpus_allowed.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression E1,E2;
@@

- set_cpus_allowed(E1, cpumask_of_cpu(E2))
+ set_cpus_allowed_ptr(E1, cpumask_of(E2))

@@
expression E;
identifier I;
@@

- set_cpus_allowed(E, I)
+ set_cpus_allowed_ptr(E, &I)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>

---
 arch/powerpc/kernel/smp.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
David Howells - March 27, 2010, 1:26 p.m.
Julia Lawall <julia@diku.dk> wrote:

> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)

That URL doesn't appear to work:

Not Found
The requested URL /) was not found on this server.
Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request.
Apache/2.2.8 (Mandriva Linux/PREFORK-6mdv2008.1) Server at coccinelle.lip6.fr Port 80

David
David Howells - March 27, 2010, 1:28 p.m.
David Howells <dhowells@redhat.com> wrote:

> > The semantic patch that makes this change is as follows:
> > (http://coccinelle.lip6.fr/)
> 
> That URL doesn't appear to work:
> 
> Not Found
> The requested URL /) was not found on this server.
> Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request.
> Apache/2.2.8 (Mandriva Linux/PREFORK-6mdv2008.1) Server at coccinelle.lip6.fr Port 80

Actually, it does.  It's just that my email client thought that the closing
bracket after it was part of the URL:-/

David

Patch

diff -u -p a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -561,12 +561,12 @@  void __init smp_cpus_done(unsigned int m
 	 * se we pin us down to CPU 0 for a short while
 	 */
 	old_mask = current->cpus_allowed;
-	set_cpus_allowed(current, cpumask_of_cpu(boot_cpuid));
+	set_cpus_allowed_ptr(current, cpumask_of(boot_cpuid));
 	
 	if (smp_ops && smp_ops->setup_cpu)
 		smp_ops->setup_cpu(boot_cpuid);
 
-	set_cpus_allowed(current, old_mask);
+	set_cpus_allowed_ptr(current, &old_mask);
 
 	snapshot_timebases();