| Message ID | 1433923603-28119-8-git-send-email-Peng.Fan@freescale.com |
|---|---|
| State | Changes Requested |
| Headers | show |
Hi Peng, On 10/06/2015 10:06, Peng Fan wrote: > From: "Ye.Li" <B37916@freescale.com> > > To resolve USB camera bandwidth issue, the patch sets recommended AQoS > setting from IC team value for peripheral and only on imx6qp. > > The address is: 0xbb0608, the value is: 0x80000201 > I understand that, if you fight against this issue, the comment can be clear and maybe redundant. Please add comments in code describing the issue, and extend the commit log to better explain the issue and the solution. > Signed-off-by: Ye.Li <B37916@freescale.com> > Signed-off-by: Peng Fan <Peng.Fan@freescale.com> > --- > arch/arm/cpu/armv7/mx6/soc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/cpu/armv7/mx6/soc.c b/arch/arm/cpu/armv7/mx6/soc.c > index 5eea9d9..0de71d56 100644 > --- a/arch/arm/cpu/armv7/mx6/soc.c > +++ b/arch/arm/cpu/armv7/mx6/soc.c > @@ -424,6 +424,9 @@ int arch_cpu_init(void) > > init_src(); > > + if (is_mx6dqp()) > + writel(0x80000201, 0xbb0608); > + > return 0; > } > > Best regards, Stefano Babic
Hi Stefano, On Wed, Jun 10, 2015 at 11:44:34AM +0200, Stefano Babic wrote: >Hi Peng, > >On 10/06/2015 10:06, Peng Fan wrote: >> From: "Ye.Li" <B37916@freescale.com> >> >> To resolve USB camera bandwidth issue, the patch sets recommended AQoS >> setting from IC team value for peripheral and only on imx6qp. >> >> The address is: 0xbb0608, the value is: 0x80000201 >> > >I understand that, if you fight against this issue, the comment can be >clear and maybe redundant. Please add comments in code describing the >issue, and extend the commit log to better explain the issue and the >solution. ok. Will add more info. > >> Signed-off-by: Ye.Li <B37916@freescale.com> >> Signed-off-by: Peng Fan <Peng.Fan@freescale.com> >> --- >> arch/arm/cpu/armv7/mx6/soc.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/arm/cpu/armv7/mx6/soc.c b/arch/arm/cpu/armv7/mx6/soc.c >> index 5eea9d9..0de71d56 100644 >> --- a/arch/arm/cpu/armv7/mx6/soc.c >> +++ b/arch/arm/cpu/armv7/mx6/soc.c >> @@ -424,6 +424,9 @@ int arch_cpu_init(void) >> >> init_src(); >> >> + if (is_mx6dqp()) >> + writel(0x80000201, 0xbb0608); >> + >> return 0; >> } >> >> > >Best regards, >Stefano Babic > >-- >===================================================================== >DENX Software Engineering GmbH, Managing Director: Wolfgang Denk >HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany >Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de >===================================================================== Regards, Peng.
diff --git a/arch/arm/cpu/armv7/mx6/soc.c b/arch/arm/cpu/armv7/mx6/soc.c index 5eea9d9..0de71d56 100644 --- a/arch/arm/cpu/armv7/mx6/soc.c +++ b/arch/arm/cpu/armv7/mx6/soc.c @@ -424,6 +424,9 @@ int arch_cpu_init(void) init_src(); + if (is_mx6dqp()) + writel(0x80000201, 0xbb0608); + return 0; }