| Message ID | 1432176653-4452-2-git-send-email-yoshihiro.shimoda.uh@renesas.com |
|---|---|
| State | Superseded |
| Headers | show |
Hi Shimoda-san, On Thu, May 21, 2015 at 4:50 AM, Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > Add binding document for Renesas PWM Timer on R-Car SoCs. Thanks for your patch! > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> with one minor nit below. > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt > +Example: R8A7790 (R-Car H2) PWM Timer node > + > + pwm0: pwm@e6e30000 { > + compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar"; > + reg = <0 0xe6e30000 0 0x10>; Length 8 is sufficient, as there are only 2 32-bit registers. > + #pwm-cells = <2>; > + clocks = <&mstp5_clks R8A7790_CLK_PWM>; > + pinctrl-0 = <&pwm0_pins>; > + pinctrl-names = "default"; > + }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Geert-san, Thank you for the review! > Sent: Thursday, May 21, 2015 5:32 PM > > Hi Shimoda-san, > > On Thu, May 21, 2015 at 4:50 AM, Yoshihiro Shimoda > <yoshihiro.shimoda.uh@renesas.com> wrote: > > Add binding document for Renesas PWM Timer on R-Car SoCs. > > Thanks for your patch! > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > with one minor nit below. Thank you for the Acked-by. > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt > > > +Example: R8A7790 (R-Car H2) PWM Timer node > > + > > + pwm0: pwm@e6e30000 { > > + compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar"; > > + reg = <0 0xe6e30000 0 0x10>; > > Length 8 is sufficient, as there are only 2 32-bit registers. Thank you for the point. I will fix it. Best regards, Yoshihiro Shimoda > > + #pwm-cells = <2>; > > + clocks = <&mstp5_clks R8A7790_CLK_PWM>; > > + pinctrl-0 = <&pwm0_pins>; > > + pinctrl-names = "default"; > > + }; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt b/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt new file mode 100644 index 0000000..c4ff798 --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt @@ -0,0 +1,27 @@ +* Renesas R-Car PWM Timer Controller + +Required Properties: +- compatible: should be one of the following. + - "renesas,pwm-rcar": for generic R-Car compatible PWM Timer + - "renesas,pwm-r8a7778": for R-Car M1A + - "renesas,pwm-r8a7779": for R-Car H1 + - "renesas,pwm-r8a7790": for R-Car H2 + - "renesas,pwm-r8a7791": for R-Car M2-W + - "renesas,pwm-r8a7794": for R-Car E2 +- reg: base address and length of the registers block for the PWM. +- #pwm-cells: should be 2. See pwm.txt in this directory for a description of + the cells format. +- clocks: clock phandle and specifier pair. +- pinctrl-0: phandle, referring to a default pin configuration node. +- pinctrl-names: Set to "default". + +Example: R8A7790 (R-Car H2) PWM Timer node + + pwm0: pwm@e6e30000 { + compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar"; + reg = <0 0xe6e30000 0 0x10>; + #pwm-cells = <2>; + clocks = <&mstp5_clks R8A7790_CLK_PWM>; + pinctrl-0 = <&pwm0_pins>; + pinctrl-names = "default"; + };
Add binding document for Renesas PWM Timer on R-Car SoCs. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- .../devicetree/bindings/pwm/renesas,pwm-rcar.txt | 27 ++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/renesas,pwm-rcar.txt