| Message ID | 1431949432-25248-1-git-send-email-prabhakar@freescale.com |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Stefano Babic |
| Headers | show |
Hi Prabhakar, On 05/18/2015 04:43 AM, Prabhakar Kushwaha wrote: > Fix below warning > arch/arm/imx-common/cpu.c:29:14: warning: ‘get_reset_cause’ defined but > not used > static char *get_reset_cause(void) > > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> > --- > arch/arm/imx-common/cpu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/imx-common/cpu.c b/arch/arm/imx-common/cpu.c > index 067d08f..0cd08cb 100644 > --- a/arch/arm/imx-common/cpu.c > +++ b/arch/arm/imx-common/cpu.c > @@ -24,6 +24,7 @@ > #include <fsl_esdhc.h> > #endif > > +#if defined(CONFIG_DISPLAY_CPUINFO) > static u32 reset_cause = -1; > > static char *get_reset_cause(void) > @@ -60,6 +61,7 @@ u32 get_imx_reset_cause(void) > { > return reset_cause; > } > +#endif > > #if defined(CONFIG_MX53) || defined(CONFIG_MX6) > #if defined(CONFIG_MX53) > This makes the dependency clear, even if it's odd. Reviewed-by: Eric Nelson <eric.nelson@boundarydevices.com>
Hi Prabhakar, Eric, On 18/05/2015 16:44, Eric Nelson wrote: > Hi Prabhakar, > > On 05/18/2015 04:43 AM, Prabhakar Kushwaha wrote: >> Fix below warning >> arch/arm/imx-common/cpu.c:29:14: warning: ‘get_reset_cause’ defined but >> not used >> static char *get_reset_cause(void) >> >> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> >> --- >> arch/arm/imx-common/cpu.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm/imx-common/cpu.c b/arch/arm/imx-common/cpu.c >> index 067d08f..0cd08cb 100644 >> --- a/arch/arm/imx-common/cpu.c >> +++ b/arch/arm/imx-common/cpu.c >> @@ -24,6 +24,7 @@ >> #include <fsl_esdhc.h> >> #endif >> >> +#if defined(CONFIG_DISPLAY_CPUINFO) >> static u32 reset_cause = -1; >> >> static char *get_reset_cause(void) >> @@ -60,6 +61,7 @@ u32 get_imx_reset_cause(void) >> { >> return reset_cause; >> } >> +#endif >> >> #if defined(CONFIG_MX53) || defined(CONFIG_MX6) >> #if defined(CONFIG_MX53) >> > > This makes the dependency clear, even if it's odd. > > Reviewed-by: Eric Nelson <eric.nelson@boundarydevices.com> > Yes, anyway this is what we already use for other SOCs (iMX31, iMX35,.. they have a local get_reset_cause() protected by this switch). Acked-by: Stefano Babic <sbabic@denx.de> Best regards, Stefano babic
On 18/05/2015 13:43, Prabhakar Kushwaha wrote: > Fix below warning > arch/arm/imx-common/cpu.c:29:14: warning: ‘get_reset_cause’ defined but > not used > static char *get_reset_cause(void) > > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic
diff --git a/arch/arm/imx-common/cpu.c b/arch/arm/imx-common/cpu.c index 067d08f..0cd08cb 100644 --- a/arch/arm/imx-common/cpu.c +++ b/arch/arm/imx-common/cpu.c @@ -24,6 +24,7 @@ #include <fsl_esdhc.h> #endif +#if defined(CONFIG_DISPLAY_CPUINFO) static u32 reset_cause = -1; static char *get_reset_cause(void) @@ -60,6 +61,7 @@ u32 get_imx_reset_cause(void) { return reset_cause; } +#endif #if defined(CONFIG_MX53) || defined(CONFIG_MX6) #if defined(CONFIG_MX53)
Fix below warning arch/arm/imx-common/cpu.c:29:14: warning: ‘get_reset_cause’ defined but not used static char *get_reset_cause(void) Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com> --- arch/arm/imx-common/cpu.c | 2 ++ 1 file changed, 2 insertions(+)