| Message ID | 77c2f1a456664204e74551ed55c4a6578d94874d.1429725549.git.yann.morin.1998@free.fr |
|---|---|
| State | Changes Requested |
| Headers | show |
On 22/04/15 20:09, Yann E. MORIN wrote: > matchbox-fakekey build-depends on xlib_libXtst, but does not select it. > > Fix that. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > --- > package/matchbox/matchbox-fakekey/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/matchbox/matchbox-fakekey/Config.in b/package/matchbox/matchbox-fakekey/Config.in > index 334f3a2..4708292 100644 > --- a/package/matchbox/matchbox-fakekey/Config.in > +++ b/package/matchbox/matchbox-fakekey/Config.in > @@ -1,2 +1,3 @@ > config BR2_PACKAGE_MATCHBOX_FAKEKEY > bool > + select BR2_PACKAGE_XLIB_LIBXTST It also depends on matchbox-lib without selecting it (like all matchbox packages BTW). Of course, matchbox-lib is always selected because matchbox selects it and matchbox-* depends on matchbox. However, if there is ever going to be a checkpackage script, it will check for consistency between select and DEPENDENCIES. So you can just as well add it now. Probably best to do that for all matchbox packages in a single commit, so not in this patch. Hence my Ack. Regards, Arnout >
diff --git a/package/matchbox/matchbox-fakekey/Config.in b/package/matchbox/matchbox-fakekey/Config.in index 334f3a2..4708292 100644 --- a/package/matchbox/matchbox-fakekey/Config.in +++ b/package/matchbox/matchbox-fakekey/Config.in @@ -1,2 +1,3 @@ config BR2_PACKAGE_MATCHBOX_FAKEKEY bool + select BR2_PACKAGE_XLIB_LIBXTST
matchbox-fakekey build-depends on xlib_libXtst, but does not select it. Fix that. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> --- package/matchbox/matchbox-fakekey/Config.in | 1 + 1 file changed, 1 insertion(+)