diff mbox

[U-Boot] socfpga: missing DECLARE_GLOBAL_DATA_PTR in timer.c

Message ID 20150408121238.GA10371@amd
State Superseded
Delegated to: Marek Vasut
Headers show

Commit Message

Pavel Machek April 8, 2015, 12:12 p.m. UTC 
for A in `find . -name "*.c"`; do if grep DECLARE_GLOBAL_DATA_PTR $A; then echo -n; else echo $A; fi; done

reveals a few files that probably should have DECLARE_GLOBAL_DATA_PTR.

This fixes it for arch/arm/cpu/armv7/socfpga/timer.c .

Signed-off-by: Pavel Machek <pavel@denx.de>

index 253cde3..2dd8376 100644

Comments

Stefan Roese April 8, 2015, 12:43 p.m. UTC | #1 
On 08.04.2015 14:12, Pavel Machek wrote:
>
> for A in `find . -name "*.c"`; do if grep DECLARE_GLOBAL_DATA_PTR $A; then echo -n; else echo $A; fi; done
>
> reveals a few files that probably should have DECLARE_GLOBAL_DATA_PTR.
>
> This fixes it for arch/arm/cpu/armv7/socfpga/timer.c .
>
> Signed-off-by: Pavel Machek <pavel@denx.de>
>
> index 253cde3..2dd8376 100644
> --- a/arch/arm/cpu/armv7/socfpga/timer.c
> +++ b/arch/arm/cpu/armv7/socfpga/timer.c
> @@ -8,6 +8,8 @@
>   #include <asm/io.h>
>   #include <asm/arch/timer.h>
>
> +DECLARE_GLOBAL_DATA_PTR;
> +

Hmmm, "gd" is not used in this file at all. So not sure if we should add 
DECLARE_GLOBAL_DATA_PTR here.

Thanks,
Stefan
diff mbox

Patch

--- a/arch/arm/cpu/armv7/socfpga/timer.c
+++ b/arch/arm/cpu/armv7/socfpga/timer.c
@@ -8,6 +8,8 @@ 
 #include <asm/io.h>
 #include <asm/arch/timer.h>
 
+DECLARE_GLOBAL_DATA_PTR;
+
 #define TIMER_LOAD_VAL		0xFFFFFFFF
 
 static const struct socfpga_timer *timer_base = (void *)CONFIG_SYS_TIMERBASE;