diff mbox

[1/1] i2c/mpc: Fix ISR return value

Message ID 1427460540-7754-1-git-send-email-amit.tomar@freescale.com
State Accepted
Headers show

Commit Message

Amit Tomar March 27, 2015, 12:49 p.m. UTC
ISR should not return IRQ_HANDLED for not handling anything.
This patch fixes the return value of ISR for the same case.

Signed-off-by: Amit Singh Tomar <amit.tomar@freescale.com>
---
 drivers/i2c/busses/i2c-mpc.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Wolfram Sang March 27, 2015, 1:47 p.m. UTC | #1
On Fri, Mar 27, 2015 at 06:19:00PM +0530, Amit Singh Tomar wrote:
> ISR should not return IRQ_HANDLED for not handling anything.
> This patch fixes the return value of ISR for the same case.
> 
> Signed-off-by: Amit Singh Tomar <amit.tomar@freescale.com>

Applied to for-next, thanks!
diff mbox

Patch

diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
index c74cc2b..2f20db1 100644
--- a/drivers/i2c/busses/i2c-mpc.c
+++ b/drivers/i2c/busses/i2c-mpc.c
@@ -95,8 +95,9 @@  static irqreturn_t mpc_i2c_isr(int irq, void *dev_id)
 		i2c->interrupt = readb(i2c->base + MPC_I2C_SR);
 		writeb(0, i2c->base + MPC_I2C_SR);
 		wake_up(&i2c->queue);
+		return IRQ_HANDLED;
 	}
-	return IRQ_HANDLED;
+	return IRQ_NONE;
 }
 
 /* Sometimes 9th clock pulse isn't generated, and slave doesn't release