| Message ID | CAGHP0pKD6NsxC0m-+uGFXJcv0PzaSXxoiPUsaH9Sb90bYqypPA@mail.gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
Hi Chris, On Thu, Mar 26, 2015 at 02:53:58PM -0700, Chris Kuethe wrote: > On Thu, Mar 26, 2015 at 4:49 AM, <andrej@inversepath.com> wrote: > > From: Andrej Rosano <andrej@inversepath.com> > > > > Hello, > > > > this series adds support for USB armory board. The patches are > > prepared against imx tree as it uses the new arch/board approach. > > > > The first patch add introduces the arch/board approach for mx5, > > as already done for mx6. > > Yep, that works. > > > The second patch adds basic support for USB armory board and > > is an updated version (v4) with the modifications described bellow. > > If I test this against HEAD as of > f643d9294f45487f22e8f33d6572530f17eff4e9, I get an error reated to > IMX_CONFIG. Please note that the patch is prepared against imx tree and not the mainline one, where the "arch/board approach" is not yet merged. Cheers, Andrej > > "board/inversepath/usbarmory/Kconfig:3:warning: config symbol defined > without type" > > Here's a diff to fix that > > diff --git a/board/inversepath/usbarmory/Kconfig > b/board/inversepath/usbarmory/Kconfig > index c2cd544..4776b1d 100644 > --- a/board/inversepath/usbarmory/Kconfig > +++ b/board/inversepath/usbarmory/Kconfig > @@ -1,8 +1,5 @@ > if TARGET_USBARMORY > > -config IMX_CONFIG > - default "board/inversepath/usbarmory/imximage.cfg" > - > config SYS_BOARD > default "usbarmory" > > diff --git a/configs/usbarmory_defconfig b/configs/usbarmory_defconfig > index 10bdd9e..237b1ca 100644 > --- a/configs/usbarmory_defconfig > +++ b/configs/usbarmory_defconfig > @@ -1,3 +1,4 @@ > CONFIG_ARM=y > CONFIG_ARCH_MX5=y > CONFIG_TARGET_USBARMORY=y > +CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/inversepath/usbarmory/imximage.cfg" > > > > Changes for v4: > > - Remove ifdef for CONFIG_FSL_ESDHC as it must always be present > > - Remove explicit GPIO input setup (all GPIO are input after reset) > > - Remove dummy board_late_init() and CONFIG_BOARD_LATE_INIT > > - Remove CONFIG_BOOTARGS > > - Fix compiling errors due to config_distro_bootcmd.h inclusion position > > Tested-by: Chris Kuethe <chris.kuethe@gmail.com> > > > Changes for v3: > > - Add config_distro support > > > > Changes for v2: > > - Fix double print_cpuinfo() call > > - Fix CONFIG_BOOTCOMMAND typo > > - Fix CONFIG_SYS_FSL_ESDHC_NUM to 1 > > > > Andrej Rosano (2): > > ARM: mx5: move to a standard arch/board approach > > ARM: mx5: add support for USB armory board > > > > > > Andrej Rosano (2): > > ARM: mx5: move to a standard arch/board approach > > ARM: mx5: add support for USB armory board > > > > -- > GDB has a 'break' feature; why doesn't it have 'fix' too? -- Andrej Rosano Inverse Path Srl <andrej@inversepath.com> http://www.inversepath.com 0x01939B21 5BB8 574E 68E8 D841 E18F D5E9 CEAD E0CF 0193 9B21
On Thu, Mar 26, 2015 at 3:23 PM, Andrej Rosano <andrej@inversepath.com> wrote: > Please note that the patch is prepared against imx tree and not the > mainline one, where the "arch/board approach" is not yet merged. OK, it all works for me.
Any chance of this being accepted into 2015.04? On Thu, Mar 26, 2015 at 3:28 PM, Chris Kuethe <chris.kuethe@gmail.com> wrote: > On Thu, Mar 26, 2015 at 3:23 PM, Andrej Rosano <andrej@inversepath.com> wrote: > >> Please note that the patch is prepared against imx tree and not the >> mainline one, where the "arch/board approach" is not yet merged. > > OK, it all works for me. > > > -- > GDB has a 'break' feature; why doesn't it have 'fix' too?
Hi Chris, On 01/04/2015 04:46, Chris Kuethe wrote: > Any chance of this being accepted into 2015.04? > It was my intention to put it into the -next branch, ready to be merged after release. Anyway, if there is still time for a new PR, I will try to let it slipping in the current. First version of this patch was sent in February and it is not odd to merge it in 2015.04. Best regards, Stefano Babic
On 01/04/2015 13:32, Stefano Babic wrote: > Hi Chris, > > On 01/04/2015 04:46, Chris Kuethe wrote: >> Any chance of this being accepted into 2015.04? >> > checpatch reports some issues by patch 2/2. Can you please fix them and resubmit ? Thanks ! Best regards, Stefano Babic
Hi Stefano, On Wed, Apr 08, 2015 at 10:53:02AM +0200, Stefano Babic wrote: > On 01/04/2015 13:32, Stefano Babic wrote: > > Hi Chris, > > > > On 01/04/2015 04:46, Chris Kuethe wrote: > >> Any chance of this being accepted into 2015.04? > >> > > > > checpatch reports some issues by patch 2/2. Can you please fix them and > resubmit ? Thanks ! Just resubmitted the v5 version. Thanks, Andrej > > Best regards, > Stefano Babic > > > -- > ===================================================================== > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de > ===================================================================== > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot -- Andrej Rosano Inverse Path Srl <andrej@inversepath.com> http://www.inversepath.com 0x01939B21 5BB8 574E 68E8 D841 E18F D5E9 CEAD E0CF 0193 9B21
On 08/04/2015 19:00, Andrej Rosano wrote: > Hi Stefano, > > On Wed, Apr 08, 2015 at 10:53:02AM +0200, Stefano Babic wrote: >> On 01/04/2015 13:32, Stefano Babic wrote: >>> Hi Chris, >>> >>> On 01/04/2015 04:46, Chris Kuethe wrote: >>>> Any chance of this being accepted into 2015.04? >>>> >>> >> >> checpatch reports some issues by patch 2/2. Can you please fix them and >> resubmit ? Thanks ! > > Just resubmitted the v5 version. > Thanks, it is ok, I merge it ! Regards, Stefano
diff --git a/board/inversepath/usbarmory/Kconfig b/board/inversepath/usbarmory/Kconfig index c2cd544..4776b1d 100644 --- a/board/inversepath/usbarmory/Kconfig +++ b/board/inversepath/usbarmory/Kconfig @@ -1,8 +1,5 @@ if TARGET_USBARMORY -config IMX_CONFIG - default "board/inversepath/usbarmory/imximage.cfg" - config SYS_BOARD default "usbarmory" diff --git a/configs/usbarmory_defconfig b/configs/usbarmory_defconfig index 10bdd9e..237b1ca 100644 --- a/configs/usbarmory_defconfig +++ b/configs/usbarmory_defconfig @@ -1,3 +1,4 @@ CONFIG_ARM=y CONFIG_ARCH_MX5=y CONFIG_TARGET_USBARMORY=y +CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/inversepath/usbarmory/imximage.cfg"