| Message ID | 1426783392-26524-1-git-send-email-yorksun@freescale.com |
|---|---|
| State | Accepted |
| Delegated to: | York Sun |
| Headers | show |
On 19 March 2015 at 10:43, York Sun <yorksun@freescale.com> wrote: > From: Scott Wood <scottwood@freescale.com> > > Otherwise the high 32 bits get truncated on 64-bit U-boot. > > Signed-off-by: Scott Wood <scottwood@freescale.com> > CC: Simon Glass <sjg@chromium.org> > --- > common/cmd_mem.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/common/cmd_mem.c b/common/cmd_mem.c > index bcb3ee3..62a0404 100644 > --- a/common/cmd_mem.c > +++ b/common/cmd_mem.c > @@ -35,9 +35,9 @@ static int mod_mem(cmd_tbl_t *, int, int, int, char * const []); > /* Display values from last command. > * Memory modify remembered values are different from display memory. > */ > -static uint dp_last_addr, dp_last_size; > -static uint dp_last_length = 0x40; > -static uint mm_last_addr, mm_last_size; > +static ulong dp_last_addr, dp_last_size; > +static ulong dp_last_length = 0x40; > +static ulong mm_last_addr, mm_last_size; > > static ulong base_address = 0; Reviewed-by: Simon Glass <sjg@chromium.org> > > -- > 1.7.9.5 >
On 03/19/2015 10:50 AM, Simon Glass wrote: > On 19 March 2015 at 10:43, York Sun <yorksun@freescale.com> wrote: >> From: Scott Wood <scottwood@freescale.com> >> >> Otherwise the high 32 bits get truncated on 64-bit U-boot. >> >> Signed-off-by: Scott Wood <scottwood@freescale.com> >> CC: Simon Glass <sjg@chromium.org> >> --- >> common/cmd_mem.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/common/cmd_mem.c b/common/cmd_mem.c >> index bcb3ee3..62a0404 100644 >> --- a/common/cmd_mem.c >> +++ b/common/cmd_mem.c >> @@ -35,9 +35,9 @@ static int mod_mem(cmd_tbl_t *, int, int, int, char * const []); >> /* Display values from last command. >> * Memory modify remembered values are different from display memory. >> */ >> -static uint dp_last_addr, dp_last_size; >> -static uint dp_last_length = 0x40; >> -static uint mm_last_addr, mm_last_size; >> +static ulong dp_last_addr, dp_last_size; >> +static ulong dp_last_length = 0x40; >> +static ulong mm_last_addr, mm_last_size; >> >> static ulong base_address = 0; > > Reviewed-by: Simon Glass <sjg@chromium.org> > Feel free to bring it in. Otherwise I will bring it in along with my other patches, targeting 2015.07. York
On 03/19/2015 10:50 AM, Simon Glass wrote: > On 19 March 2015 at 10:43, York Sun <yorksun@freescale.com> wrote: >> From: Scott Wood <scottwood@freescale.com> >> >> Otherwise the high 32 bits get truncated on 64-bit U-boot. >> >> Signed-off-by: Scott Wood <scottwood@freescale.com> >> CC: Simon Glass <sjg@chromium.org> >> --- >> common/cmd_mem.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/common/cmd_mem.c b/common/cmd_mem.c >> index bcb3ee3..62a0404 100644 >> --- a/common/cmd_mem.c >> +++ b/common/cmd_mem.c >> @@ -35,9 +35,9 @@ static int mod_mem(cmd_tbl_t *, int, int, int, char * const []); >> /* Display values from last command. >> * Memory modify remembered values are different from display memory. >> */ >> -static uint dp_last_addr, dp_last_size; >> -static uint dp_last_length = 0x40; >> -static uint mm_last_addr, mm_last_size; >> +static ulong dp_last_addr, dp_last_size; >> +static ulong dp_last_length = 0x40; >> +static ulong mm_last_addr, mm_last_size; >> >> static ulong base_address = 0; > > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to fsl-qoriq master, awaiting upstream. York
diff --git a/common/cmd_mem.c b/common/cmd_mem.c index bcb3ee3..62a0404 100644 --- a/common/cmd_mem.c +++ b/common/cmd_mem.c @@ -35,9 +35,9 @@ static int mod_mem(cmd_tbl_t *, int, int, int, char * const []); /* Display values from last command. * Memory modify remembered values are different from display memory. */ -static uint dp_last_addr, dp_last_size; -static uint dp_last_length = 0x40; -static uint mm_last_addr, mm_last_size; +static ulong dp_last_addr, dp_last_size; +static ulong dp_last_length = 0x40; +static ulong mm_last_addr, mm_last_size; static ulong base_address = 0;