diff mbox

[U-Boot] fastboot: Proper download gadget unregister and clear when cable is missing

Message ID 1426440515-4577-1-git-send-email-contact@paulk.fr
State Accepted
Delegated to: Łukasz Majewski
Headers show

Commit Message

Paul Kocialkowski March 15, 2015, 5:28 p.m. UTC
Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
 common/cmd_fastboot.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Marek Vasut March 15, 2015, 6:12 p.m. UTC | #1
On Sunday, March 15, 2015 at 06:28:35 PM, Paul Kocialkowski wrote:
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>  common/cmd_fastboot.c | 2 ++
>  1 file changed, 2 insertions(+)

+CC Lukasz and Steve.

> diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c
> index 346ab80..7956a5b 100644
> --- a/common/cmd_fastboot.c
> +++ b/common/cmd_fastboot.c
> @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int
> argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected()) {
>  		puts("\rUSB cable not detected.\n" \
>  		     "Command exit.\n");
> +		g_dnl_unregister();
> +		g_dnl_clear_detach();
>  		return CMD_RET_FAILURE;
>  	}

Best regards,
Marek Vasut
Paul Kocialkowski March 22, 2015, 12:05 p.m. UTC | #2
Hi,

Le dimanche 15 mars 2015 à 19:12 +0100, Marek Vasut a écrit :
> On Sunday, March 15, 2015 at 06:28:35 PM, Paul Kocialkowski wrote:
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > ---
> >  common/cmd_fastboot.c | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> +CC Lukasz and Steve.

Is there anything holding back that patch at this point?

> > diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c
> > index 346ab80..7956a5b 100644
> > --- a/common/cmd_fastboot.c
> > +++ b/common/cmd_fastboot.c
> > @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int
> > argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected()) {
> >  		puts("\rUSB cable not detected.\n" \
> >  		     "Command exit.\n");
> > +		g_dnl_unregister();
> > +		g_dnl_clear_detach();
> >  		return CMD_RET_FAILURE;
> >  	}
> 
> Best regards,
> Marek Vasut
Marek Vasut March 22, 2015, 12:24 p.m. UTC | #3
On Sunday, March 22, 2015 at 01:05:14 PM, Paul Kocialkowski wrote:
> Hi,
> 
> Le dimanche 15 mars 2015 à 19:12 +0100, Marek Vasut a écrit :
> > On Sunday, March 15, 2015 at 06:28:35 PM, Paul Kocialkowski wrote:
> > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > > ---
> > > 
> > >  common/cmd_fastboot.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > 
> > +CC Lukasz and Steve.
> 
> Is there anything holding back that patch at this point?

Hi

Lukasz is the USB gadget side maintainer, so please wait for him to pick this.

Thanks

Best regards,
Marek Vasut
Paul Kocialkowski March 22, 2015, 1:18 p.m. UTC | #4
Le dimanche 22 mars 2015 à 13:24 +0100, Marek Vasut a écrit :
> On Sunday, March 22, 2015 at 01:05:14 PM, Paul Kocialkowski wrote:
> > Hi,
> > 
> > Le dimanche 15 mars 2015 à 19:12 +0100, Marek Vasut a écrit :
> > > On Sunday, March 15, 2015 at 06:28:35 PM, Paul Kocialkowski wrote:
> > > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > > > ---
> > > > 
> > > >  common/cmd_fastboot.c | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > 
> > > +CC Lukasz and Steve.
> > 
> > Is there anything holding back that patch at this point?
> 
> Hi
> 
> Lukasz is the USB gadget side maintainer, so please wait for him to
> pick this.

Oh okay, I thought it was up to you, my mistake.
Marek Vasut March 22, 2015, 4:46 p.m. UTC | #5
On Sunday, March 22, 2015 at 02:18:09 PM, Paul Kocialkowski wrote:
> Le dimanche 22 mars 2015 à 13:24 +0100, Marek Vasut a écrit :
> > On Sunday, March 22, 2015 at 01:05:14 PM, Paul Kocialkowski wrote:
> > > Hi,
> > > 
> > > Le dimanche 15 mars 2015 à 19:12 +0100, Marek Vasut a écrit :
> > > > On Sunday, March 15, 2015 at 06:28:35 PM, Paul Kocialkowski wrote:
> > > > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > > > > ---
> > > > > 
> > > > >  common/cmd_fastboot.c | 2 ++
> > > > >  1 file changed, 2 insertions(+)
> > > > 
> > > > +CC Lukasz and Steve.
> > > 
> > > Is there anything holding back that patch at this point?
> > 
> > Hi
> > 
> > Lukasz is the USB gadget side maintainer, so please wait for him to
> > pick this.
> 
> Oh okay, I thought it was up to you, my mistake.

I can pick them in case Lukasz is inactive for too long, give it a week
and ping me again in such case please.

Best regards,
Marek Vasut
diff mbox

Patch

diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c
index 346ab80..7956a5b 100644
--- a/common/cmd_fastboot.c
+++ b/common/cmd_fastboot.c
@@ -23,6 +23,8 @@  static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
 	if (!g_dnl_board_usb_cable_connected()) {
 		puts("\rUSB cable not detected.\n" \
 		     "Command exit.\n");
+		g_dnl_unregister();
+		g_dnl_clear_detach();
 		return CMD_RET_FAILURE;
 	}