diff mbox

[03/15] toolchain-common: default to Y for LARGEFILE

Message ID 1426270934-15499-4-git-send-email-gustavo@zacarias.com.ar
State Superseded
Headers show

Commit Message

Gustavo Zacarias March 13, 2015, 6:22 p.m. UTC
This will allow us to remove largefile handling in the tree without
breaking things while doing so.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 toolchain/toolchain-common.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Yann E. MORIN March 14, 2015, 10:34 p.m. UTC | #1
Gustavo, All,

On 2015-03-13 15:22 -0300, Gustavo Zacarias spake thusly:
> This will allow us to remove largefile handling in the tree without
> breaking things while doing so.

This means that, with this patch applied, it is still possible to build
an internal uClibc toolchain without LFS, and packages would believe LFS
is available...

Please add a patch just before this one, that turns
BR2_TOOLCHAIN_BUILDROOT_LARGEFILE into a promptless option that defaults
to 'y'.

Afterward, you can add my:

    Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>  toolchain/toolchain-common.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/toolchain/toolchain-common.in b/toolchain/toolchain-common.in
> index 304afe4..7eb22ce 100644
> --- a/toolchain/toolchain-common.in
> +++ b/toolchain/toolchain-common.in
> @@ -7,6 +7,7 @@ source "package/gdb/Config.in.host"
>  
>  config BR2_LARGEFILE
>  	bool
> +	default y
>  
>  config BR2_INET_IPV6
>  	bool
> -- 
> 2.0.5
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox

Patch

diff --git a/toolchain/toolchain-common.in b/toolchain/toolchain-common.in
index 304afe4..7eb22ce 100644
--- a/toolchain/toolchain-common.in
+++ b/toolchain/toolchain-common.in
@@ -7,6 +7,7 @@  source "package/gdb/Config.in.host"
 
 config BR2_LARGEFILE
 	bool
+	default y
 
 config BR2_INET_IPV6
 	bool