| Message ID | 20100207235205.GI32246@kryten (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Benjamin Herrenschmidt |
| Headers | show |
On Mon, Feb 8, 2010 at 5:22 AM, Anton Blanchard <anton@samba.org> wrote: > > The cede latency stuff is relatively new and we don't need to complain about > it not working on older firmware. > > Signed-off-by: Anton Blanchard <anton@samba.org> Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com> Seems like a reasonable change. CC'ing Vaidy and Gautham to look even more closely at the patch. Balbir
* Balbir Singh <balbir@linux.vnet.ibm.com> [2010-02-08 16:37:37]: > On Mon, Feb 8, 2010 at 5:22 AM, Anton Blanchard <anton@samba.org> wrote: > > > > The cede latency stuff is relatively new and we don't need to complain about > > it not working on older firmware. > > > > Signed-off-by: Anton Blanchard <anton@samba.org> > > Acked-by: Balbir Singh <balbir@linux.vnet.ibm.com> > > Seems like a reasonable change. CC'ing Vaidy and Gautham to look even > more closely at the patch. Hi Anton, Removing the printk is reasonable. The failure case is noise in older firmware while the success case may not be very informative. Thanks, Vaidy
Index: powerpc.git/arch/powerpc/platforms/pseries/hotplug-cpu.c =================================================================== --- powerpc.git.orig/arch/powerpc/platforms/pseries/hotplug-cpu.c 2010-02-05 17:36:22.509710985 +1100 +++ powerpc.git/arch/powerpc/platforms/pseries/hotplug-cpu.c 2010-02-05 17:36:30.118124726 +1100 @@ -396,14 +396,6 @@ static int parse_cede_parameters(void) __pa(cede_parameters), CEDE_LATENCY_PARAM_MAX_LENGTH); - if (call_status != 0) - printk(KERN_INFO "CEDE_LATENCY: \ - %s %s Error calling get-system-parameter(0x%x)\n", - __FILE__, __func__, call_status); - else - printk(KERN_INFO "CEDE_LATENCY: \ - get-system-parameter successful.\n"); - return call_status; }
The cede latency stuff is relatively new and we don't need to complain about it not working on older firmware. Signed-off-by: Anton Blanchard <anton@samba.org> ---