diff mbox

[U-Boot,06/14] mx35pdk: Use the default CONFIG_SYS_PBSIZE

Message ID 1425316478-17059-6-git-send-email-fabio.estevam@freescale.com
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Commit Message

Fabio Estevam March 2, 2015, 5:14 p.m. UTC
Entering the maximum number of characters defined by CONFIG_SYS_CBSIZE into
the console and hitting enter afterwards, causes a hang in the system because
CONFIG_SYS_PBSIZE is not capable of storing the extra characters of the error
message:
"Unknown command '' - try 'help'".

Use the default CONFIG_SYS_PBSIZE definition from config_fallbacks.h to solve
this problem.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 include/configs/mx35pdk.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Stefano Babic March 4, 2015, 8:08 a.m. UTC | #1
On 02/03/2015 18:14, Fabio Estevam wrote:
> Entering the maximum number of characters defined by CONFIG_SYS_CBSIZE into
> the console and hitting enter afterwards, causes a hang in the system because
> CONFIG_SYS_PBSIZE is not capable of storing the extra characters of the error
> message:
> "Unknown command '' - try 'help'".
> 
> Use the default CONFIG_SYS_PBSIZE definition from config_fallbacks.h to solve
> this problem.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  include/configs/mx35pdk.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/include/configs/mx35pdk.h b/include/configs/mx35pdk.h
> index a145f08..ae021a6 100644
> --- a/include/configs/mx35pdk.h
> +++ b/include/configs/mx35pdk.h
> @@ -138,8 +138,6 @@
>  
>  #define CONFIG_AUTO_COMPLETE
>  #define CONFIG_SYS_CBSIZE	256	/* Console I/O Buffer Size */
> -/* Print Buffer Size */
> -#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
>  #define CONFIG_SYS_MAXARGS	16	/* max number of command args */
>  #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE /* Boot Argument Buffer Size */
>  
> 

Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/include/configs/mx35pdk.h b/include/configs/mx35pdk.h
index a145f08..ae021a6 100644
--- a/include/configs/mx35pdk.h
+++ b/include/configs/mx35pdk.h
@@ -138,8 +138,6 @@ 
 
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE	256	/* Console I/O Buffer Size */
-/* Print Buffer Size */
-#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
 #define CONFIG_SYS_MAXARGS	16	/* max number of command args */
 #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE /* Boot Argument Buffer Size */