| Message ID | 1424858960-26755-1-git-send-email-abrodkin@synopsys.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On 25 February 2015 at 03:09, Alexey Brodkin <Alexey.Brodkin@synopsys.com> wrote: > GD_RELOCADDR, GD_RELOC_OFF & GD_START_ADDR_SP are generic members of > global data structure so why don't we allow architectures other than ARM > to use it. > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> > Cc: Simon Glass <sjg@chromium.org> > Cc: Tom Rini <trini@ti.com> > --- > lib/asm-offsets.c | 4 ---- > 1 file changed, 4 deletions(-) Acked-by: Simon Glass <sjg@chromium.org> > > diff --git a/lib/asm-offsets.c b/lib/asm-offsets.c > index 129bc3e..221ebbf 100644 > --- a/lib/asm-offsets.c > +++ b/lib/asm-offsets.c > @@ -32,15 +32,11 @@ int main(void) > DEFINE(GD_MALLOC_BASE, offsetof(struct global_data, malloc_base)); > #endif > > -#if defined(CONFIG_ARM) > - > DEFINE(GD_RELOCADDR, offsetof(struct global_data, relocaddr)); > > DEFINE(GD_RELOC_OFF, offsetof(struct global_data, reloc_off)); > > DEFINE(GD_START_ADDR_SP, offsetof(struct global_data, start_addr_sp)); > > -#endif > - > return 0; > } > -- > 2.1.0 >
On Wed, Feb 25, 2015 at 01:09:20PM +0300, Alexey Brodkin wrote: > GD_RELOCADDR, GD_RELOC_OFF & GD_START_ADDR_SP are generic members of > global data structure so why don't we allow architectures other than ARM > to use it. > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> > Cc: Simon Glass <sjg@chromium.org> > Cc: Tom Rini <trini@ti.com> > Acked-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/lib/asm-offsets.c b/lib/asm-offsets.c index 129bc3e..221ebbf 100644 --- a/lib/asm-offsets.c +++ b/lib/asm-offsets.c @@ -32,15 +32,11 @@ int main(void) DEFINE(GD_MALLOC_BASE, offsetof(struct global_data, malloc_base)); #endif -#if defined(CONFIG_ARM) - DEFINE(GD_RELOCADDR, offsetof(struct global_data, relocaddr)); DEFINE(GD_RELOC_OFF, offsetof(struct global_data, reloc_off)); DEFINE(GD_START_ADDR_SP, offsetof(struct global_data, start_addr_sp)); -#endif - return 0; }
GD_RELOCADDR, GD_RELOC_OFF & GD_START_ADDR_SP are generic members of global data structure so why don't we allow architectures other than ARM to use it. Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> Cc: Simon Glass <sjg@chromium.org> Cc: Tom Rini <trini@ti.com> --- lib/asm-offsets.c | 4 ---- 1 file changed, 4 deletions(-)