diff mbox

Export BR2_EXTERNAL for post-build/support scripts

Message ID 1423064097-1151-1-git-send-email-julian@jusst.de
State Superseded
Headers show

Commit Message

Julian Scheel Feb. 4, 2015, 3:34 p.m. UTC
Especially post-build scripts might want to make use of BR2_EXTERNAL variable,
so export it.

Signed-off-by: Julian Scheel <julian@jusst.de>
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)

Comments

Yann E. MORIN Feb. 4, 2015, 4:21 p.m. UTC | #1
Julian, All,

On 2015-02-04 17:19 +0100, Yann E. MORIN spake thusly:
> On 2015-02-04 16:34 +0100, Julian Scheel spake thusly:
> > Especially post-build scripts might want to make use of BR2_EXTERNAL variable,
> > so export it.
> 
> As discussed on IRC, there is another solution to export BR2_EXTERNAL,
> which is to add it to EXTRA_ENV, like so:
[--SNIP--]

And to complete my previous reply: I don;t really mind which way we're
doing it: your solution or mine are equaly acceptable to me.

Regards,
Yann E. MORIN.

> > Signed-off-by: Julian Scheel <julian@jusst.de>
> > ---
> >  Makefile | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Makefile b/Makefile
> > index e554a30..92ae3fa 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -349,6 +349,7 @@ endif
> >  # Scripts in support/ or post-build scripts may need to reference
> >  # these locations, so export them so it is easier to use
> >  export BR2_CONFIG
> > +export BR2_EXTERNAL
> >  export TARGET_DIR
> >  export STAGING_DIR
> >  export HOST_DIR
> > -- 
> > 2.2.1
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot@busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
> 
> -- 
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Romain Naour Feb. 7, 2015, 3:11 p.m. UTC | #2
Hi Yann, Julian, All,

Le 04/02/2015 17:21, Yann E. MORIN a écrit :
> Julian, All,
> 
> On 2015-02-04 17:19 +0100, Yann E. MORIN spake thusly:
>> On 2015-02-04 16:34 +0100, Julian Scheel spake thusly:
>>> Especially post-build scripts might want to make use of BR2_EXTERNAL variable,
>>> so export it.
>>
>> As discussed on IRC, there is another solution to export BR2_EXTERNAL,
>> which is to add it to EXTRA_ENV, like so:
> [--SNIP--]
> 
> And to complete my previous reply: I don;t really mind which way we're
> doing it: your solution or mine are equaly acceptable to me.
> 
> Regards,
> Yann E. MORIN.
> 
>>> Signed-off-by: Julian Scheel <julian@jusst.de>
>>> ---
>>>  Makefile | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Makefile b/Makefile
>>> index e554a30..92ae3fa 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -349,6 +349,7 @@ endif
>>>  # Scripts in support/ or post-build scripts may need to reference
>>>  # these locations, so export them so it is easier to use
>>>  export BR2_CONFIG
>>> +export BR2_EXTERNAL

I have applied the same patch to be able to use BR2_EXTERNAL in a post-image
script. But I'm agree that adding BR2_EXTERNAL to EXTRA_ENV is enough.

Best regards,
Romain
>>>  export TARGET_DIR
>>>  export STAGING_DIR
>>>  export HOST_DIR
>>> -- 
>>> 2.2.1
>>>
>>> _______________________________________________
>>> buildroot mailing list
>>> buildroot@busybox.net
>>> http://lists.busybox.net/mailman/listinfo/buildroot
>>
>> -- 
>> .-----------------.--------------------.------------------.--------------------.
>> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
>> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
>> | +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
>> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
>> '------------------------------^-------^------------------^--------------------'
>> _______________________________________________
>> buildroot mailing list
>> buildroot@busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
Yann E. MORIN Feb. 7, 2015, 9:48 p.m. UTC | #3
Julian, All,

On 2015-02-04 16:34 +0100, Julian Scheel spake thusly:
> Especially post-build scripts might want to make use of BR2_EXTERNAL variable,
> so export it.

Peter has applied the alternative patch I submitted.

Thanks for the report! :-)

Regards,
Yann E. MORIN.

> Signed-off-by: Julian Scheel <julian@jusst.de>
> ---
>  Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Makefile b/Makefile
> index e554a30..92ae3fa 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -349,6 +349,7 @@ endif
>  # Scripts in support/ or post-build scripts may need to reference
>  # these locations, so export them so it is easier to use
>  export BR2_CONFIG
> +export BR2_EXTERNAL
>  export TARGET_DIR
>  export STAGING_DIR
>  export HOST_DIR
> -- 
> 2.2.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox

Patch

diff --git a/Makefile b/Makefile
index e554a30..92ae3fa 100644
--- a/Makefile
+++ b/Makefile
@@ -349,6 +349,7 @@  endif
 # Scripts in support/ or post-build scripts may need to reference
 # these locations, so export them so it is easier to use
 export BR2_CONFIG
+export BR2_EXTERNAL
 export TARGET_DIR
 export STAGING_DIR
 export HOST_DIR