diff mbox

[U-Boot,1/3] mmc: dw_mmc: fixed the wrong bit control

Message ID 1423032520-18165-2-git-send-email-jh80.chung@samsung.com
State Accepted
Delegated to: Pantelis Antoniou
Headers show

Commit Message

Jaehoon Chung Feb. 4, 2015, 6:48 a.m. UTC
If mode is not DDR-mode, then it needs to clear it.

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
 drivers/mmc/dw_mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Pantelis Antoniou Feb. 23, 2015, 5:38 p.m. UTC | #1
Hi Jaehoon,

> On Feb 4, 2015, at 08:48 , Jaehoon Chung <jh80.chung@samsung.com> wrote:
> 
> If mode is not DDR-mode, then it needs to clear it.
> 
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> ---
> drivers/mmc/dw_mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
> index b18c75d..76fa0b0 100644
> --- a/drivers/mmc/dw_mmc.c
> +++ b/drivers/mmc/dw_mmc.c
> @@ -321,7 +321,7 @@ static void dwmci_set_ios(struct mmc *mmc)
> 	if (mmc->ddr_mode)
> 		regs |= DWMCI_DDR_MODE;
> 	else
> -		regs &= DWMCI_DDR_MODE;
> +		regs &= ~DWMCI_DDR_MODE;
> 
> 	dwmci_writel(host, DWMCI_UHS_REG, regs);
> 
> -- 
> 1.9.1
> 

This is the same patch as to the previous version that I applied.
So dropping this.

— Pantelis
diff mbox

Patch

diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
index b18c75d..76fa0b0 100644
--- a/drivers/mmc/dw_mmc.c
+++ b/drivers/mmc/dw_mmc.c
@@ -321,7 +321,7 @@  static void dwmci_set_ios(struct mmc *mmc)
 	if (mmc->ddr_mode)
 		regs |= DWMCI_DDR_MODE;
 	else
-		regs &= DWMCI_DDR_MODE;
+		regs &= ~DWMCI_DDR_MODE;
 
 	dwmci_writel(host, DWMCI_UHS_REG, regs);