| Message ID | 1422302600-21514-1-git-send-email-kbastian@mail.uni-paderborn.de |
|---|---|
| State | New |
| Headers | show |
On 26 January 2015 at 20:03, Bastian Koppelmann <kbastian@mail.uni-paderborn.de> wrote: > The following changes since commit 1ac0206b2ae1ffaeec564f110664a3a77bafafd2: > > qemu-timer.c: Trim list of included headers (2015-01-26 18:15:54 +0000) > > are available in the git repository at: > > https://github.com/bkoppelmann/qemu-tricore-upstream.git tags/pull-tricore20150126-2 > > for you to fetch changes up to 24c3bf03341ada63a0728f2bdfd2b7c226ad958e: > > target-tricore: Add instructions of RRR opcode format (2015-01-26 19:56:46 +0000) > > ---------------------------------------------------------------- > tricore bugfixes and RR1, RR2, RRPW and RRR insn > > ---------------------------------------------------------------- Looks like this would introduce a new clang warning: /home/petmay01/linaro/qemu-for-merges/target-tricore/translate.c:1049:23: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] if ((up_shift == 32)) { ~~~~~~~~~^~~~~ /home/petmay01/linaro/qemu-for-merges/target-tricore/translate.c:1049:23: note: remove extraneous parentheses around the comparison to silence this warning if ((up_shift == 32)) { ~ ^ ~ /home/petmay01/linaro/qemu-for-merges/target-tricore/translate.c:1049:23: note: use '=' to turn this equality comparison into an assignment if ((up_shift == 32)) { ^~ = We've nearly managed to eradicate all our clang warnings so I don't want to add more at this point -- could you fix this and resend the pullreq, please? thanks -- PMM
On 27 January 2015 at 11:45, Bastian Koppelmann <kbastian@mail.uni-paderborn.de> wrote: > Sure thing. With this many clang warning, I think I should also build with > clang on my machine too. You don't have to (though of course you can if you like): I build pull requests with a pretty wide set of target configs which I don't expect every submaintainer to have convenient access to. (I don't even run my own pull requests through the full set of config builds before sending them :-)) I recommend configuring with '--cc=clang' '--cxx=clang++' '--extra-cflags=-fsanitize=undefined' (and do use separate build directories so it doesn't get mixed up with the gcc build objects). The undefined sanitizer will print warnings at runtime about things that are undefined behaviour in C, so it's worth exercising your code under that build occasionally to see what falls out. -- PMM
On 01/27/2015 10:40 AM, Peter Maydell wrote: > On 26 January 2015 at 20:03, Bastian Koppelmann > <kbastian@mail.uni-paderborn.de> wrote: >> The following changes since commit 1ac0206b2ae1ffaeec564f110664a3a77bafafd2: >> >> qemu-timer.c: Trim list of included headers (2015-01-26 18:15:54 +0000) >> >> are available in the git repository at: >> >> https://github.com/bkoppelmann/qemu-tricore-upstream.git tags/pull-tricore20150126-2 >> >> for you to fetch changes up to 24c3bf03341ada63a0728f2bdfd2b7c226ad958e: >> >> target-tricore: Add instructions of RRR opcode format (2015-01-26 19:56:46 +0000) >> >> ---------------------------------------------------------------- >> tricore bugfixes and RR1, RR2, RRPW and RRR insn >> >> ---------------------------------------------------------------- > Looks like this would introduce a new clang warning: > > /home/petmay01/linaro/qemu-for-merges/target-tricore/translate.c:1049:23: > warning: equality > comparison with extraneous parentheses [-Wparentheses-equality] > if ((up_shift == 32)) { > ~~~~~~~~~^~~~~ > /home/petmay01/linaro/qemu-for-merges/target-tricore/translate.c:1049:23: > note: remove extraneous > parentheses around the comparison to silence this warning > if ((up_shift == 32)) { > ~ ^ ~ > /home/petmay01/linaro/qemu-for-merges/target-tricore/translate.c:1049:23: > note: use '=' to turn > this equality comparison into an assignment > if ((up_shift == 32)) { > ^~ > = > > We've nearly managed to eradicate all our clang warnings so I > don't want to add more at this point -- could you fix this > and resend the pullreq, please? Sure thing. With this many clang warning, I think I should also build with clang on my machine too. Cheers, Bastian > thanks > -- PMM
The following changes since commit 1ac0206b2ae1ffaeec564f110664a3a77bafafd2: qemu-timer.c: Trim list of included headers (2015-01-26 18:15:54 +0000) are available in the git repository at: https://github.com/bkoppelmann/qemu-tricore-upstream.git tags/pull-tricore20150126-2 for you to fetch changes up to 24c3bf03341ada63a0728f2bdfd2b7c226ad958e: target-tricore: Add instructions of RRR opcode format (2015-01-26 19:56:46 +0000) ---------------------------------------------------------------- tricore bugfixes and RR1, RR2, RRPW and RRR insn ---------------------------------------------------------------- Bastian Koppelmann (8): target-tricore: Several translator and cpu model fixes target-tricore: calculate av bits before saturation target-tricore: Fix bugs found by coverity target-tricore: split up suov32 into suov32_pos and suov32_neg target-tricore: target-tricore: Add instructions of RR1 opcode format, that have 0x93 as first opcode target-tricore: Add instructions of RR2 opcode format target-tricore: Add instructions of RRPW opcode format target-tricore: Add instructions of RRR opcode format Peter Maydell (1): target-tricore: Add missing ULL suffix on 64 bit constant target-tricore/cpu.c | 2 +- target-tricore/cpu.h | 1 + target-tricore/helper.h | 8 + target-tricore/op_helper.c | 232 +++++++++++++++++--- target-tricore/translate.c | 448 ++++++++++++++++++++++++++++++++++++++- target-tricore/tricore-opcodes.h | 2 +- 6 files changed, 659 insertions(+), 34 deletions(-) -- 2.2.2