diff mbox

[U-Boot,04/17] sunxi: video: Drop disabling of backend / lcdc / hdmi encoder on modeset

Message ID 1419447989-21959-5-git-send-email-hdegoede@redhat.com
State Accepted
Delegated to: Ian Campbell
Headers show

Commit Message

Hans de Goede Dec. 24, 2014, 7:06 p.m. UTC
The enable flags are initialized to 0 already by engines_init, so now that
we no longer retry the mode-set, the disabling of the blocks in
sunxi_mode_set() is a no-op.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/video/sunxi_display.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Ian Campbell Dec. 28, 2014, 9:34 a.m. UTC | #1
On Wed, 2014-12-24 at 20:06 +0100, Hans de Goede wrote:
> The enable flags are initialized to 0 already by engines_init, so now that
> we no longer retry the mode-set, the disabling of the blocks in
> sunxi_mode_set() is a no-op.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Ian Campbell <ijc@hellion.org.uk>
diff mbox

Patch

diff --git a/drivers/video/sunxi_display.c b/drivers/video/sunxi_display.c
index a0a0613..ced5ce5 100644
--- a/drivers/video/sunxi_display.c
+++ b/drivers/video/sunxi_display.c
@@ -561,10 +561,6 @@  static void sunxi_mode_set(const struct ctfb_res_modes *mode, char *monitor,
 	int clk_div, clk_double;
 	bool hdmi_mode = strcmp(monitor, "hdmi") == 0;
 
-	clrbits_le32(&hdmi->video_ctrl, SUNXI_HDMI_VIDEO_CTRL_ENABLE);
-	clrbits_le32(&lcdc->ctrl, SUNXI_LCDC_CTRL_TCON_ENABLE);
-	clrbits_le32(&de_be->mode, SUNXI_DE_BE_MODE_START);
-
 	sunxi_composer_mode_set(mode, address);
 	sunxi_lcdc_mode_set(mode, &clk_div, &clk_double);
 	sunxi_hdmi_mode_set(mode, hdmi_mode, clk_div, clk_double);