| Message ID | 1418267521-26896-1-git-send-email-sjg@chromium.org |
|---|---|
| State | Accepted |
| Delegated to: | Simon Glass |
| Headers | show |
On 10 December 2014 at 20:12, Simon Glass <sjg@chromium.org> wrote: > We should include common.h before other includes. This actually causes > a build error on chromebook_link. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- Applied to u-boot-x86 (it fixes a build error for chromeos_link)
diff --git a/drivers/bios_emulator/besys.c b/drivers/bios_emulator/besys.c index 752a928..02c4286 100644 --- a/drivers/bios_emulator/besys.c +++ b/drivers/bios_emulator/besys.c @@ -48,8 +48,8 @@ ****************************************************************************/ #define __io -#include <asm/io.h> #include <common.h> +#include <asm/io.h> #include "biosemui.h" /*------------------------- Global Variables ------------------------------*/ diff --git a/drivers/bios_emulator/bios.c b/drivers/bios_emulator/bios.c index 152d70a..dd4c0a4 100644 --- a/drivers/bios_emulator/bios.c +++ b/drivers/bios_emulator/bios.c @@ -42,8 +42,8 @@ ****************************************************************************/ #define __io -#include <asm/io.h> #include <common.h> +#include <asm/io.h> #include "biosemui.h" /*----------------------------- Implementation ----------------------------*/
We should include common.h before other includes. This actually causes a build error on chromebook_link. Signed-off-by: Simon Glass <sjg@chromium.org> --- drivers/bios_emulator/besys.c | 2 +- drivers/bios_emulator/bios.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)