| Message ID | 1416952759-15204-1-git-send-email-suriyan.r@gmail.com |
|---|---|
| State | Deferred |
| Delegated to: | Stefan Roese |
| Headers | show |
Just a gentle ping to see if this can be commented on/Acked/Merged ? Thanks - Suiryan On Tue, Nov 25, 2014 at 1:59 PM, Suriyan Ramasami <suriyan.r@gmail.com> wrote: > When kwboot is invoked with -t <tty> the code implicitly assumes that one > of -b (boot message) or -d (debug message) with an image file is specified. > This is not necessarily true. > > This allows kwboot -t <tty> to function. > > Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com> > --- > > Changes in v1: > - First try > > tools/kwboot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/kwboot.c b/tools/kwboot.c > index 1368b4c..449564e 100644 > --- a/tools/kwboot.c > +++ b/tools/kwboot.c > @@ -785,7 +785,7 @@ main(int argc, char **argv) > perror("debugmsg"); > goto out; > } > - } else { > + } else if (bootmsg) { > rc = kwboot_bootmsg(tty, bootmsg); > if (rc) { > perror("bootmsg"); > -- > 1.8.3.1 >
On 03.12.2014 19:16, Suriyan Ramasami wrote: > Just a gentle ping to see if this can be commented on/Acked/Merged ? Acked-by: Stefan Roese <sr@denx.de> Thanks, Stefan
diff --git a/tools/kwboot.c b/tools/kwboot.c index 1368b4c..449564e 100644 --- a/tools/kwboot.c +++ b/tools/kwboot.c @@ -785,7 +785,7 @@ main(int argc, char **argv) perror("debugmsg"); goto out; } - } else { + } else if (bootmsg) { rc = kwboot_bootmsg(tty, bootmsg); if (rc) { perror("bootmsg");
When kwboot is invoked with -t <tty> the code implicitly assumes that one of -b (boot message) or -d (debug message) with an image file is specified. This is not necessarily true. This allows kwboot -t <tty> to function. Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com> --- Changes in v1: - First try tools/kwboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)