diff mbox

[U-Boot,1/7] imx6: add macro define inclusion

Message ID 1415555488-37665-2-git-send-email-john.tobias.ph@gmail.com
State Changes Requested
Delegated to: Stefano Babic
Headers show

Commit Message

John Tobias Nov. 9, 2014, 5:51 p.m. UTC 
add a macro define inclusion to compile the function.
iMX6SL doesn't have an MMDC_P1_BASE_ADDR in the header.
It will break the build if the SPL features is enabled
for iMX6SL.
---
 arch/arm/cpu/armv7/mx6/ddr.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Fabio Estevam Nov. 9, 2014, 11:26 p.m. UTC | #1 
Hi John,

On Sun, Nov 9, 2014 at 3:51 PM, John Tobias <john.tobias.ph@gmail.com> wrote:
> add a macro define inclusion to compile the function.
> iMX6SL doesn't have an MMDC_P1_BASE_ADDR in the header.
> It will break the build if the SPL features is enabled
> for iMX6SL.
> ---

You missed to add the Signed-off-by tag in your patches. Please run
./scripts/checkpatch on your patches.

Regards,

Fabio Estevam
John Tobias Nov. 9, 2014, 11:42 p.m. UTC | #2 
Hi Fabio,

I didn't notice that one... Thanks for the info.

Regards,

john

On Sun, Nov 9, 2014 at 3:26 PM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi John,
>
> On Sun, Nov 9, 2014 at 3:51 PM, John Tobias <john.tobias.ph@gmail.com> wrote:
>> add a macro define inclusion to compile the function.
>> iMX6SL doesn't have an MMDC_P1_BASE_ADDR in the header.
>> It will break the build if the SPL features is enabled
>> for iMX6SL.
>> ---
>
> You missed to add the Signed-off-by tag in your patches. Please run
> ./scripts/checkpatch on your patches.
>
> Regards,
>
> Fabio Estevam
diff mbox

Patch

diff --git a/arch/arm/cpu/armv7/mx6/ddr.c b/arch/arm/cpu/armv7/mx6/ddr.c
index 7a9b03a..3beeded 100644
--- a/arch/arm/cpu/armv7/mx6/ddr.c
+++ b/arch/arm/cpu/armv7/mx6/ddr.c
@@ -182,6 +182,7 @@  void mx6sdl_dram_iocfg(unsigned width,
  * For details on each register, refer to the IMX6DQRM and/or IMX6SDLRM
  * section titled MMDC initialization
  */
+#if defined(CONFIG_MX6QDL) || defined(CONFIG_MX6Q) || defined(CONFIG_MX6D)
 #define MR(val, ba, cmd, cs1) \
 	((val << 16) | (1 << 15) | (cmd << 4) | (cs1 << 3) | ba)
 void mx6_dram_cfg(const struct mx6_ddr_sysinfo *sysinfo,
@@ -489,3 +490,4 @@  void mx6_dram_cfg(const struct mx6_ddr_sysinfo *sysinfo,
 	/* wait for auto-ZQ calibration to complete */
 	mdelay(1);
 }
+#endif