| Message ID | 1415117278-1255-2-git-send-email-andrew.ruder@elecsyscorp.com |
|---|---|
| State | Superseded |
| Delegated to: | Heiko Schocher |
| Headers | show |
Hello Andrew, Am 04.11.2014 17:07, schrieb Andrew Ruder: > UBI drivers error out if writebufsize is not filled in correctly. Grab > this information from the CFI flash_info struct. > > Signed-off-by: Andrew Ruder<andrew.ruder@elecsyscorp.com> > Cc: Wolfgang Denk<wd@denx.de> > Cc: Heiko Schocher<hs@denx.de> > Cc: Stefan Roese<sr@denx.de> > --- > drivers/mtd/cfi_mtd.c | 1 + > 1 file changed, 1 insertion(+) Patch already posted on the ML, see [1] If this Patch works for you, could you send an "Acked-by" for it? > > diff --git a/drivers/mtd/cfi_mtd.c b/drivers/mtd/cfi_mtd.c > index ac805ff..d4c9609 100644 > --- a/drivers/mtd/cfi_mtd.c > +++ b/drivers/mtd/cfi_mtd.c > @@ -226,6 +226,7 @@ int cfi_mtd_init(void) > mtd->flags = MTD_CAP_NORFLASH; > mtd->size = fi->size; > mtd->writesize = 1; > + mtd->writebufsize = fi->buffer_size; ^ should be cfi This is a typo ... your patch would not compile ... please just ack the patch [1], thanks! bye, Heiko [1] Patchwork [U-Boot,v2] mtd, cfi, ubi: add missing writebufsize initialization http://patchwork.ozlabs.org/patch/405260/
On Wed, Nov 05, 2014 at 08:00:21AM +0100, Heiko Schocher wrote: > >diff --git a/drivers/mtd/cfi_mtd.c b/drivers/mtd/cfi_mtd.c > >index ac805ff..d4c9609 100644 > >--- a/drivers/mtd/cfi_mtd.c > >+++ b/drivers/mtd/cfi_mtd.c > >@@ -226,6 +226,7 @@ int cfi_mtd_init(void) > > mtd->flags = MTD_CAP_NORFLASH; > > mtd->size = fi->size; > > mtd->writesize = 1; > >+ mtd->writebufsize = fi->buffer_size; > ^ should be cfi > > This is a typo ... your patch would not compile ... please just > ack the patch [1], thanks! I responded on the other thread with your other patch. I apologize for not seeing it originally. This patch, imo, is correct though and definitely compiles - not a typo! - Andy
Hello Andrew, Am 05.11.2014 20:23, schrieb Andrew Ruder: > On Wed, Nov 05, 2014 at 08:00:21AM +0100, Heiko Schocher wrote: >>> diff --git a/drivers/mtd/cfi_mtd.c b/drivers/mtd/cfi_mtd.c >>> index ac805ff..d4c9609 100644 >>> --- a/drivers/mtd/cfi_mtd.c >>> +++ b/drivers/mtd/cfi_mtd.c >>> @@ -226,6 +226,7 @@ int cfi_mtd_init(void) >>> mtd->flags = MTD_CAP_NORFLASH; >>> mtd->size = fi->size; >>> mtd->writesize = 1; >>> + mtd->writebufsize = fi->buffer_size; >> ^ should be cfi >> >> This is a typo ... your patch would not compile ... please just >> ack the patch [1], thanks! > > I responded on the other thread with your other patch. I apologize for > not seeing it originally. This patch, imo, is correct though and No problem! > definitely compiles - not a typo! Yes, sorry for that. bye, Heiko
diff --git a/drivers/mtd/cfi_mtd.c b/drivers/mtd/cfi_mtd.c index ac805ff..d4c9609 100644 --- a/drivers/mtd/cfi_mtd.c +++ b/drivers/mtd/cfi_mtd.c @@ -226,6 +226,7 @@ int cfi_mtd_init(void) mtd->flags = MTD_CAP_NORFLASH; mtd->size = fi->size; mtd->writesize = 1; + mtd->writebufsize = fi->buffer_size; mtd->_erase = cfi_mtd_erase; mtd->_read = cfi_mtd_read;
UBI drivers error out if writebufsize is not filled in correctly. Grab this information from the CFI flash_info struct. Signed-off-by: Andrew Ruder <andrew.ruder@elecsyscorp.com> Cc: Wolfgang Denk <wd@denx.de> Cc: Heiko Schocher <hs@denx.de> Cc: Stefan Roese <sr@denx.de> --- drivers/mtd/cfi_mtd.c | 1 + 1 file changed, 1 insertion(+)