| Message ID | 1413747007-24990-11-git-send-email-patrickdepinguin@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
Hi Thomas, On Sun, Oct 19, 2014 at 9:30 PM, Thomas De Schampheleire <patrickdepinguin@gmail.com> wrote: > From: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> > > This patch will save all config.log files of the failed package in the > result tarball, to help problem analysis. This is typically useful for > autotools packages, although the added logic does not check that > explicitly (i.e. any failing package that has a config.log file in the > output directory will see this file saved). Could you add the same mechanism for CMakeCache.txt files (which are kind of equivalent of config.log, but for CMake-based packages)? > > The saving of config.log files happens recursively, the directory > structure is preserved in the result directory. > > Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Regards,
On Sun, Oct 19, 2014 at 9:44 PM, Samuel Martin <s.martin49@gmail.com> wrote: > Hi Thomas, > > On Sun, Oct 19, 2014 at 9:30 PM, Thomas De Schampheleire > <patrickdepinguin@gmail.com> wrote: >> From: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> >> >> This patch will save all config.log files of the failed package in the >> result tarball, to help problem analysis. This is typically useful for >> autotools packages, although the added logic does not check that >> explicitly (i.e. any failing package that has a config.log file in the >> output directory will see this file saved). > > Could you add the same mechanism for CMakeCache.txt files (which are > kind of equivalent of config.log, but for CMake-based packages)? Yes this could be done, but I'd like to do it as a follow-up patch. Best regards, Thomas
diff --git a/scripts/autobuild-run b/scripts/autobuild-run index 1960f53..4803fa1 100755 --- a/scripts/autobuild-run +++ b/scripts/autobuild-run @@ -44,9 +44,6 @@ # # TODO: # -# - Include the config.log file (when it exists) in the tarball for -# failed builds when the failure occurs on an autotools package. -# # - Instead of excluding all configurations that have # BR2_PACKAGE_CLASSPATH=y, improve the script to detect whether the # necessary host machine requirements are there to build classpath. @@ -520,6 +517,26 @@ def send_results(result, **kwargs): extract_end_log(os.path.join(resultdir, "build-end.log")) + def copy_config_log_files(): + """Recursively copy any config.log files from the failing package""" + + reason = get_failure_reason() + if not reason: + return + + srcroot = os.path.join(outputdir, "build", '-'.join(reason)) + destroot = os.path.join(resultdir, '-'.join(reason)) + + for root, dirs, files in os.walk(srcroot): + dest = os.path.join(destroot, os.path.relpath(root, srcroot)) + + for file in files: + if file == 'config.log': + os.makedirs(dest) + shutil.copy(os.path.join(root, file), os.path.join(dest, file)) + + copy_config_log_files() + resultf = open(os.path.join(resultdir, "status"), "w+") if result == 0: resultf.write("OK")