[PULL,00/28] target-mips queue

Hi,

This pull request has been assembled from pending target-mips patches which
look good to me and received in my opinion sufficient review comments. They
were tested mainly in context of MIPS. Please have a look and pull.

Thanks,
Leon

Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Aurelien Jarno <aurelien@aurel32.net>

The following changes since commit b1d28ec6a7dbdaadda39d29322f0de694aeb0b74:

  Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20141010' into staging (2014-10-10 14:55:29 +0100)

are available in the git repository at:

  git://github.com/lalrae/qemu.git tags/mips-20141015

for you to fetch changes up to 340fff722d8a7cf9c0d4f1e1b4fad03a145a9657:

  target-mips: Remove unused gen_load_ACX, gen_store_ACX and cpu_ACX (2014-10-14 13:29:15 +0100)

----------------------------------------------------------------
MIPS patches 2014-10-15

Changes:
* MIPS64R6 (unprivileged) support
* fix for broken MIPS16 and microMIPS
* SYNCI improvement
* unused MIPS code removal

----------------------------------------------------------------
Dongxue Zhang (1):
  target-mips/translate.c: Update OPC_SYNCI

Leon Alrae (17):
  target-mips: define ISA_MIPS64R6
  target-mips: signal RI Exception on instructions removed in R6
  target-mips: add SELEQZ and SELNEZ instructions
  target-mips: move LL and SC instructions
  target-mips: extract decode_opc_special* from decode_opc
  target-mips: split decode_opc_special* into *_r6 and *_legacy
  target-mips: signal RI Exception on DSP and Loongson instructions
  target-mips: move PREF, CACHE, LLD and SCD instructions
  target-mips: redefine Integer Multiply and Divide instructions
  target-mips: move CLO, DCLO, CLZ, DCLZ, SDBBP and free special2 in R6
  target-mips: Status.UX/SX/KX enable 32-bit address wrapping
  target-mips: add AUI, LSA and PCREL instruction families
  softfloat: add functions corresponding to IEEE-2008 min/maxNumMag
  target-mips: add new Floating Point instructions
  target-mips: do not allow Status.FR=0 mode in 64-bit FPU
  mips_malta: update malta's pseudo-bootloader - replace JR with JALR
  target-mips: define a new generic CPU supporting MIPS64 Release 6 ISA

Peter Maydell (5):
  target-mips/dsp_helper.c: Remove unused function get_DSPControl_24()
  target-mips/op_helper.c: Remove unused do_lbu() function
  target-mips/translate.c: Add ifdef guard around check_mips64()
  target-mips/dsp_helper.c: Add ifdef guards around various functions
  target-mips: Remove unused gen_load_ACX, gen_store_ACX and cpu_ACX

Yongbok Kim (5):
  target-mips: add ALIGN, DALIGN, BITSWAP and DBITSWAP instructions
  target-mips: add compact and CP1 branches
  target-mips: add new Floating Point Comparison instructions
  target-mips: remove JR, BLTZAL, BGEZAL and add NAL, BAL instructions
  target-mips: fix broken MIPS16 and microMIPS

 disas/mips.c                 |  211 ++-
 fpu/softfloat.c              |   37 +-
 hw/mips/mips_malta.c         |   10 +-
 include/fpu/softfloat.h      |    4 +
 target-mips/cpu.h            |   31 +-
 target-mips/dsp_helper.c     |   26 +-
 target-mips/helper.h         |   52 +
 target-mips/mips-defs.h      |   28 +-
 target-mips/op_helper.c      |  239 ++-
 target-mips/translate.c      | 4114 ++++++++++++++++++++++++++++++------------
 target-mips/translate_init.c |   30 +
 11 files changed, 3563 insertions(+), 1219 deletions(-)

On 15 October 2014 11:53, Leon Alrae <leon.alrae@imgtec.com> wrote:
> Hi,
>
> This pull request has been assembled from pending target-mips patches which
> look good to me and received in my opinion sufficient review comments. They
> were tested mainly in context of MIPS. Please have a look and pull.

Thanks for putting this together; I'll look it over shortly.

One question for now:

> Leon Alrae (17):
>   softfloat: add functions corresponding to IEEE-2008 min/maxNumMag

Can you confirm that you're happy for your softfloat changes
to be licensed under both of the softfloat-2a and softfloat-2b
licenses, please?

(We're trying to relicense those files right now, so any new
changes need to be dual-license.)

PS: do you happen to be at KVM Forum today?

-- PMM

On 16/10/2014 10:49, Peter Maydell wrote:
> 
> One question for now:
> 
>> Leon Alrae (17):
>>   softfloat: add functions corresponding to IEEE-2008 min/maxNumMag
> 
> Can you confirm that you're happy for your softfloat changes
> to be licensed under both of the softfloat-2a and softfloat-2b
> licenses, please?

Yes, I'm happy with my softfloat changes to be licensed under softfloat
2a and 2b licenses.

> PS: do you happen to be at KVM Forum today?

No, I won't be there unfortunately.

Regards,
Leon

On 15 October 2014 10:53, Leon Alrae <leon.alrae@imgtec.com> wrote:
> Hi,
>
> This pull request has been assembled from pending target-mips patches which
> look good to me and received in my opinion sufficient review comments. They
> were tested mainly in context of MIPS. Please have a look and pull.

These all look good -- I have applied the pull request to master.

Thanks for stepping up to do this submaintainer work.

-- PMM

On 22 October 2014 13:08, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 15 October 2014 10:53, Leon Alrae <leon.alrae@imgtec.com> wrote:
>> Hi,
>>
>> This pull request has been assembled from pending target-mips patches which
>> look good to me and received in my opinion sufficient review comments. They
>> were tested mainly in context of MIPS. Please have a look and pull.
>
> These all look good -- I have applied the pull request to master.

...but after I did that I noticed these which you should probably
send a patch to fix:
target-mips/op_helper.c: In function ‘bitswap’:
target-mips/op_helper.c:270: warning: integer constant is too large
for ‘long’ type
target-mips/op_helper.c:271: warning: integer constant is too large
for ‘long’ type
target-mips/op_helper.c:272: warning: integer constant is too large
for ‘long’ type
target-mips/op_helper.c:273: warning: integer constant is too large
for ‘long’ type
target-mips/op_helper.c:274: warning: integer constant is too large
for ‘long’ type
target-mips/op_helper.c:275: warning: integer constant is too large
for ‘long’ type

64 bit literal constants need to be suffixed with "ULL", like:
 0x5555555555555555ULL
or some of our compilers complain. I think this is the Windows
build, which we don't currently have set to warnings-as-errors
due to other longstanding warnings.

thanks
-- PMM

On 22/10/2014 13:22, Peter Maydell wrote:
> On 22 October 2014 13:08, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 15 October 2014 10:53, Leon Alrae <leon.alrae@imgtec.com> wrote:
>>> Hi,
>>>
>>> This pull request has been assembled from pending target-mips patches which
>>> look good to me and received in my opinion sufficient review comments. They
>>> were tested mainly in context of MIPS. Please have a look and pull.
>>
>> These all look good -- I have applied the pull request to master.
> 
> ...but after I did that I noticed these which you should probably
> send a patch to fix:
> target-mips/op_helper.c: In function ‘bitswap’:
> target-mips/op_helper.c:270: warning: integer constant is too large
> for ‘long’ type
> target-mips/op_helper.c:271: warning: integer constant is too large
> for ‘long’ type
> target-mips/op_helper.c:272: warning: integer constant is too large
> for ‘long’ type
> target-mips/op_helper.c:273: warning: integer constant is too large
> for ‘long’ type
> target-mips/op_helper.c:274: warning: integer constant is too large
> for ‘long’ type
> target-mips/op_helper.c:275: warning: integer constant is too large
> for ‘long’ type
> 
> 64 bit literal constants need to be suffixed with "ULL", like:
>  0x5555555555555555ULL
> or some of our compilers complain. I think this is the Windows
> build, which we don't currently have set to warnings-as-errors
> due to other longstanding warnings.

Sorry for that, I will send the patch shortly.

Leon