| Message ID | 20141008215911.GA28764@amd |
|---|---|
| State | Accepted |
| Delegated to: | Marek Vasut |
| Headers | show |
On Wednesday, October 08, 2014 at 11:59:11 PM, Pavel Machek wrote: > Make boards with Altera Socfpga print real board names. > > Signed-off-by: Pavel Machek <pavel@denx.de> > Please wait with this one until the boards really reach mainline. Also, the patch is missing tags in the subject, please add them in. Best regards, Marek Vasut
On Thu 2014-10-09 00:07:04, Marek Vasut wrote: > On Wednesday, October 08, 2014 at 11:59:11 PM, Pavel Machek wrote: > > Make boards with Altera Socfpga print real board names. > > > > Signed-off-by: Pavel Machek <pavel@denx.de> > > > > Please wait with this one until the boards really reach mainline. Also, > the patch is missing tags in the subject, please add them in. I wanted you to apply it to your tree. That way, the boards reach mainline with right names... Pavel
On Thursday, October 09, 2014 at 12:12:28 AM, Pavel Machek wrote: > On Thu 2014-10-09 00:07:04, Marek Vasut wrote: > > On Wednesday, October 08, 2014 at 11:59:11 PM, Pavel Machek wrote: > > > Make boards with Altera Socfpga print real board names. > > > > > > Signed-off-by: Pavel Machek <pavel@denx.de> > > > > Please wait with this one until the boards really reach mainline. Also, > > the patch is missing tags in the subject, please add them in. > > I wanted you to apply it to your tree. That way, the boards reach > mainline with right names... What kind of names are you referring to ? Also, I see the CC list is also broken :( Best regards, Marek Vasut
On Thu 2014-10-09 00:24:34, Marek Vasut wrote: > On Thursday, October 09, 2014 at 12:12:28 AM, Pavel Machek wrote: > > On Thu 2014-10-09 00:07:04, Marek Vasut wrote: > > > On Wednesday, October 08, 2014 at 11:59:11 PM, Pavel Machek wrote: > > > > Make boards with Altera Socfpga print real board names. > > > > > > > > Signed-off-by: Pavel Machek <pavel@denx.de> > > > > > > Please wait with this one until the boards really reach mainline. Also, > > > the patch is missing tags in the subject, please add them in. > > > > I wanted you to apply it to your tree. That way, the boards reach > > mainline with right names... > > What kind of names are you referring to ? Also, I see the CC list is also broken > :( Read the patch. Currently, u-boot prints confusing board names during boot. Now, you can explain what is wrong with the CC list, and what kind of tags you would like to see in the subject, or you could simply treat this patch as a bug report. You are the maintainter now, so you can fix it any way you want. I wanted to help, but clearly that is not welcome. Pavel
Hi Pavel, On Thu, 9 Oct 2014 00:48:12 +0200, Pavel Machek <pavel@denx.de> wrote: > On Thu 2014-10-09 00:24:34, Marek Vasut wrote: > > On Thursday, October 09, 2014 at 12:12:28 AM, Pavel Machek wrote: > > > On Thu 2014-10-09 00:07:04, Marek Vasut wrote: > > > > On Wednesday, October 08, 2014 at 11:59:11 PM, Pavel Machek wrote: > > > > > Make boards with Altera Socfpga print real board names. > > > > > > > > > > Signed-off-by: Pavel Machek <pavel@denx.de> > > > > > > > > Please wait with this one until the boards really reach mainline. Also, > > > > the patch is missing tags in the subject, please add them in. > > > > > > I wanted you to apply it to your tree. That way, the boards reach > > > mainline with right names... > > > > What kind of names are you referring to ? Also, I see the CC list is also broken > > :( > > Read the patch. > > Currently, u-boot prints confusing board names during boot. I'm not sure I understand either what the patch does. It touches board/altera/socfpga/socfpga_cyclone5.c, which, AFAIU, is specific to one single board. So, in this patch, CONFIG_BOARD_NAME can only contain the Cyclone5 board name. Does any other board use this file with a different CONFIG_BOARD_NAME? Amicalement,
On Thu 2014-10-09 00:55:59, Albert ARIBAUD wrote: > Hi Pavel, > > On Thu, 9 Oct 2014 00:48:12 +0200, Pavel Machek <pavel@denx.de> wrote: > > > On Thu 2014-10-09 00:24:34, Marek Vasut wrote: > > > On Thursday, October 09, 2014 at 12:12:28 AM, Pavel Machek wrote: > > > > On Thu 2014-10-09 00:07:04, Marek Vasut wrote: > > > > > On Wednesday, October 08, 2014 at 11:59:11 PM, Pavel Machek wrote: > > > > > > Make boards with Altera Socfpga print real board names. > > > > > > > > > > > > Signed-off-by: Pavel Machek <pavel@denx.de> > > > > > > > > > > Please wait with this one until the boards really reach mainline. Also, > > > > > the patch is missing tags in the subject, please add them in. > > > > > > > > I wanted you to apply it to your tree. That way, the boards reach > > > > mainline with right names... > > > > > > What kind of names are you referring to ? Also, I see the CC list is also broken > > > :( > > > > Read the patch. > > > > Currently, u-boot prints confusing board names during boot. > > I'm not sure I understand either what the patch does. It touches > board/altera/socfpga/socfpga_cyclone5.c, which, AFAIU, is specific to > one single board. So, in this patch, CONFIG_BOARD_NAME can only contain > the Cyclone5 board name. Does any other board use this file with a > different CONFIG_BOARD_NAME? On marex's branch from 20141007 (e8e77ee38da8760d0fa3ebdae37924db71f1e496): pavel@amd:~/wagabuibui/u-boot$ cat board/denx/mcvevk/socfpga_cyclone5.c #include "../../altera/socfpga/socfpga_cyclone5.c" Initial patch even said it is against Marek's tree... Pavel
Hi Pavel, On Thu, 9 Oct 2014 01:04:33 +0200, Pavel Machek <pavel@denx.de> wrote: > On Thu 2014-10-09 00:55:59, Albert ARIBAUD wrote: > > Hi Pavel, > > > > On Thu, 9 Oct 2014 00:48:12 +0200, Pavel Machek <pavel@denx.de> wrote: > > > > > On Thu 2014-10-09 00:24:34, Marek Vasut wrote: > > > > On Thursday, October 09, 2014 at 12:12:28 AM, Pavel Machek wrote: > > > > > On Thu 2014-10-09 00:07:04, Marek Vasut wrote: > > > > > > On Wednesday, October 08, 2014 at 11:59:11 PM, Pavel Machek wrote: > > > > > > > Make boards with Altera Socfpga print real board names. > > > > > > > > > > > > > > Signed-off-by: Pavel Machek <pavel@denx.de> > > > > > > > > > > > > Please wait with this one until the boards really reach mainline. Also, > > > > > > the patch is missing tags in the subject, please add them in. > > > > > > > > > > I wanted you to apply it to your tree. That way, the boards reach > > > > > mainline with right names... > > > > > > > > What kind of names are you referring to ? Also, I see the CC list is also broken > > > > :( > > > > > > Read the patch. > > > > > > Currently, u-boot prints confusing board names during boot. > > > > I'm not sure I understand either what the patch does. It touches > > board/altera/socfpga/socfpga_cyclone5.c, which, AFAIU, is specific to > > one single board. So, in this patch, CONFIG_BOARD_NAME can only contain > > the Cyclone5 board name. Does any other board use this file with a > > different CONFIG_BOARD_NAME? > > On marex's branch from 20141007 > (e8e77ee38da8760d0fa3ebdae37924db71f1e496): > > pavel@amd:~/wagabuibui/u-boot$ cat board/denx/mcvevk/socfpga_cyclone5.c > #include "../../altera/socfpga/socfpga_cyclone5.c" Ok, so the Denx MCV EVK board uses the same file as the Altera SoCFPGA board, and without your patch, the Denx board would show itself as the Altera one. Since the list of files touched by the patch does not provide any clue as to which other board(s) use the Altera SoCFPGA, can you post a V2 of your patch, with an amended commit message listing the other board(s) involved? > Initial patch even said it is against Marek's tree... Indeed -- I just did not realize that this board/ file was included in another board/ file. Regarding tags, "arm:" and "socfpga:" should be fine. Amicalement,
On Thursday, October 09, 2014 at 12:48:12 AM, Pavel Machek wrote: > On Thu 2014-10-09 00:24:34, Marek Vasut wrote: > > On Thursday, October 09, 2014 at 12:12:28 AM, Pavel Machek wrote: > > > On Thu 2014-10-09 00:07:04, Marek Vasut wrote: > > > > On Wednesday, October 08, 2014 at 11:59:11 PM, Pavel Machek wrote: > > > > > Make boards with Altera Socfpga print real board names. > > > > > > > > > > Signed-off-by: Pavel Machek <pavel@denx.de> > > > > > > > > Please wait with this one until the boards really reach mainline. > > > > Also, the patch is missing tags in the subject, please add them in. > > > > > > I wanted you to apply it to your tree. That way, the boards reach > > > mainline with right names... > > > > What kind of names are you referring to ? Also, I see the CC list is also > > broken > > > > :( > > Read the patch. > > Currently, u-boot prints confusing board names during boot. > > Now, you can explain what is wrong with the CC list It did contain non-existent email addresses, I fixed that. > , and what kind of > tags you would like to see in the subject arm: and socfpga: please ... Albert, this is correct, right ? > or you could simply treat this patch as a bug report. How is this a bug if there is currently only one board supported which has the correct name please ? > You are the maintainter now, so you can > fix it any way you want. I wanted to help, but clearly that is not > welcome. Please let me remind you that a custodian is NOT here to do your share of the work for you and that nasty remarks will get you exactly nowhere. If you plan to help, then please prepare a patch which applies against current mainline and meets all the usual criteria ; this should not be that difficult afterall. Best regards, Marek Vasut
On Thursday, October 09, 2014 at 01:04:33 AM, Pavel Machek wrote: > On Thu 2014-10-09 00:55:59, Albert ARIBAUD wrote: > > Hi Pavel, > > > > On Thu, 9 Oct 2014 00:48:12 +0200, Pavel Machek <pavel@denx.de> wrote: > > > On Thu 2014-10-09 00:24:34, Marek Vasut wrote: > > > > On Thursday, October 09, 2014 at 12:12:28 AM, Pavel Machek wrote: > > > > > On Thu 2014-10-09 00:07:04, Marek Vasut wrote: > > > > > > On Wednesday, October 08, 2014 at 11:59:11 PM, Pavel Machek wrote: > > > > > > > Make boards with Altera Socfpga print real board names. > > > > > > > > > > > > > > Signed-off-by: Pavel Machek <pavel@denx.de> > > > > > > > > > > > > Please wait with this one until the boards really reach mainline. > > > > > > Also, the patch is missing tags in the subject, please add them > > > > > > in. > > > > > > > > > > I wanted you to apply it to your tree. That way, the boards reach > > > > > mainline with right names... > > > > > > > > What kind of names are you referring to ? Also, I see the CC list is > > > > also broken > > > > > > > > :( > > > > > > Read the patch. > > > > > > Currently, u-boot prints confusing board names during boot. > > > > I'm not sure I understand either what the patch does. It touches > > board/altera/socfpga/socfpga_cyclone5.c, which, AFAIU, is specific to > > one single board. So, in this patch, CONFIG_BOARD_NAME can only contain > > the Cyclone5 board name. Does any other board use this file with a > > different CONFIG_BOARD_NAME? > > On marex's branch from 20141007 > (e8e77ee38da8760d0fa3ebdae37924db71f1e496): > > pavel@amd:~/wagabuibui/u-boot$ cat board/denx/mcvevk/socfpga_cyclone5.c > #include "../../altera/socfpga/socfpga_cyclone5.c" > > Initial patch even said it is against Marek's tree... U-Boot-socfpga shows this: $ git show e8e77ee38da8760d0fa3ebdae37924db71f1e496 fatal: bad object e8e77ee38da8760d0fa3ebdae37924db71f1e496 Now I am really thoroughly confused, sorry. Best regards, Marek Vasut
> > On marex's branch from 20141007 > > (e8e77ee38da8760d0fa3ebdae37924db71f1e496): > > > > pavel@amd:~/wagabuibui/u-boot$ cat board/denx/mcvevk/socfpga_cyclone5.c > > #include "../../altera/socfpga/socfpga_cyclone5.c" > > > > Initial patch even said it is against Marek's tree... > > U-Boot-socfpga shows this: > > $ git show e8e77ee38da8760d0fa3ebdae37924db71f1e496 > fatal: bad object e8e77ee38da8760d0fa3ebdae37924db71f1e496 > > Now I am really thoroughly confused, sorry. As I said, it was on your branch from 20141007. Pavel
> > You are the maintainter now, so you can > > fix it any way you want. I wanted to help, but clearly that is not > > welcome. > > Please let me remind you that a custodian is NOT here to do your share > of the work for you and that nasty remarks will get you exactly > nowhere. There's nothing like "my share of work". I'm not a slave, I can choose what I do with my free time. > If you plan to help, then please prepare a patch which applies against > current mainline and meets all the usual criteria ; this should not be > that difficult afterall. As I explained in my initial email, this is against your internal tree, not mainline. And yes, meeting "all the usual criteria" is hard, when the criteria are not listed anywhere. If you can provide the list, it may be easier. For the record, I believe that wasting bandwith with patch resend because "it does not have right keywords in subject" would be wrong, especially since I clearly got your attention already. Other "usual criteria" you like to reject my patches with are "uses printf()" and "there are other bugs around the one you fixed". Those are not "usual criteria" in other opensource projects. Pavel
Hi! > > On marex's branch from 20141007 > > (e8e77ee38da8760d0fa3ebdae37924db71f1e496): > > > > pavel@amd:~/wagabuibui/u-boot$ cat board/denx/mcvevk/socfpga_cyclone5.c > > #include "../../altera/socfpga/socfpga_cyclone5.c" > > Ok, so the Denx MCV EVK board uses the same file as the Altera SoCFPGA > board, and without your patch, the Denx board would show itself as the > Altera one. > > Since the list of files touched by the patch does not provide any clue > as to which other board(s) use the Altera SoCFPGA, can you post a V2 of > your patch, with an amended commit message listing the other board(s) > involved? > > > Initial patch even said it is against Marek's tree... > > Indeed -- I just did not realize that this board/ file was included > in another board/ file. It is not -- yet. AFAICT that is in Marek's tree (or was at some point) but not in mainline. Marek can do git apply at this point, or maybe solve it some other way, but I don't think posting V2 would be helpful. Pavel
diff --git a/board/altera/socfpga/socfpga_cyclone5.c b/board/altera/socfpga/socfpga_cyclone5.c index 7661ac9..43307f5 100644 --- a/board/altera/socfpga/socfpga_cyclone5.c +++ b/board/altera/socfpga/socfpga_cyclone5.c @@ -17,7 +17,7 @@ DECLARE_GLOBAL_DATA_PTR; */ int checkboard(void) { - puts("BOARD: Altera SoCFPGA Cyclone5 Board\n"); + puts("BOARD: " CONFIG_BOARD_NAME "\n"); return 0; } diff --git a/include/configs/mcvevk.h b/include/configs/mcvevk.h index 09b1eb2..0c5d688 100644 --- a/include/configs/mcvevk.h +++ b/include/configs/mcvevk.h @@ -11,6 +11,8 @@ #include "../../board/denx/mcvevk/iocsr_config.h" #include "../../board/denx/mcvevk/pll_config.h" +#define CONFIG_BOARD_NAME "Denx MCVEVK Board" + /* U-Boot Commands */ #define CONFIG_SYS_NO_FLASH #ifndef MCVEVK_RECOVERY diff --git a/include/configs/socfpga_cyclone5.h b/include/configs/socfpga_cyclone5.h index bee328c..2a42389 100644 --- a/include/configs/socfpga_cyclone5.h +++ b/include/configs/socfpga_cyclone5.h @@ -11,6 +11,8 @@ #include "../../board/altera/socfpga/iocsr_config.h" #include "../../board/altera/socfpga/pll_config.h" +#define CONFIG_BOARD_NAME "Altera SoCFPGA Cyclone5 Board" + /* U-Boot Commands */ #define CONFIG_SYS_NO_FLASH #include <config_cmd_default.h> diff --git a/include/configs/wagabuibui.h b/include/configs/wagabuibui.h index 458e1a1..c85bee4 100644 --- a/include/configs/wagabuibui.h +++ b/include/configs/wagabuibui.h @@ -11,6 +11,8 @@ #include "../../board/motec/wagabuibui/iocsr_config.h" #include "../../board/motec/wagabuibui/pll_config.h" +#define CONFIG_BOARD_NAME "Wagabuibui Board" + /* U-Boot Commands */ #define CONFIG_SYS_NO_FLASH #include <config_cmd_default.h>
Make boards with Altera Socfpga print real board names. Signed-off-by: Pavel Machek <pavel@denx.de> --- This is against Marek's tree. Ignore the missing file for mainline.