| Message ID | 7dc3e2f0cf37f042723a473e1de04e5e432f7c75.1410692670.git.yann.morin.1998@free.fr |
|---|---|
| State | Changes Requested |
| Headers | show |
On Sun, Sep 14, 2014 at 1:07 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > The document's main file is already part of MANUAL_SOURCES, so no need > to explicitly depend on it. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Samuel Martin <s.martin49@gmail.com> > Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com> Acked-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Just a side note: I've been wondering if we should change the extension of the manual source files from .txt to .asciidoc. This seems to be the default extension and will make sure that vim selects the right syntax highlighting by default. I guess other editors would do the same (not tested). What do you think of that? Or is it unnecessary? On Debian, vim does not parse the modeline by default for security reasons, so the first two lines in each of these .txt files do not help there. Best regards, Thomas
On Sun, Sep 14, 2014 at 1:07 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > The document's main file is already part of MANUAL_SOURCES, so no need > to explicitly depend on it. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Samuel Martin <s.martin49@gmail.com> > Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com> Acked-by: Samuel Martin <s.martin49@gmail.com>
Thomas, All, On 2014-09-19 22:18 +0200, Thomas De Schampheleire spake thusly: > On Sun, Sep 14, 2014 at 1:07 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > The document's main file is already part of MANUAL_SOURCES, so no need > > to explicitly depend on it. > > > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > Cc: Samuel Martin <s.martin49@gmail.com> > > Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com> > > Acked-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> > > Just a side note: I've been wondering if we should change the > extension of the manual source files from .txt to .asciidoc. This > seems to be the default extension and will make sure that vim selects > the right syntax highlighting by default. I guess other editors would > do the same (not tested). > What do you think of that? Or is it unnecessary? > On Debian, vim does not parse the modeline by default for security > reasons, so the first two lines in each of these .txt files do not > help there. Well, my vim surely does. OK, it's Ubuntu, not Debian. Still... I tried with an empty ~/.vim: I still get asciidoc syntax highlighting. .asciidoc is overkill, I think. I'm not against, but may we wait for after the series is applied? Trying not to get too much on my plate... Hehe! ;-) > Best regards, > Thomas
diff --git a/docs/manual/manual.mk b/docs/manual/manual.mk index bae517b..135ab3d 100644 --- a/docs/manual/manual.mk +++ b/docs/manual/manual.mk @@ -98,8 +98,7 @@ $$(O)/docs/$(1)/$(1).$(4): to make through the command line: \ 'PATH=/path/to/custom-xsltproc/bin:$$$${PATH} make manual-pdf') else -$$(O)/docs/$(1)/$(1).$(4): docs/$(1)/$(1).txt \ - $$($$(call UPPERCASE,$(1))_SOURCES) \ +$$(O)/docs/$(1)/$(1).$(4): $$($$(call UPPERCASE,$(1))_SOURCES) \ manual-check-dependencies \ manual-check-dependencies-$(3) \ manual-prepare-sources
The document's main file is already part of MANUAL_SOURCES, so no need to explicitly depend on it. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Samuel Martin <s.martin49@gmail.com> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com> --- docs/manual/manual.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)