diff mbox

arch/arc: fix atomics selection

Message ID 1410468406-10535-1-git-send-email-yann.morin.1998@free.fr
State Accepted
Headers show

Commit Message

Yann E. MORIN Sept. 11, 2014, 8:46 p.m. UTC 
Due to a kconfig limitation, we can't select a no-prompt symbol that
gets its dependencies by being conditionally re-defined in one or more
if-blocks, like we currently do for BR2_ARCH_HAS_ATOMICS.

As a workaround to this issue, we just redefine that symbol in the arc
if-block, like we do for all other architectures, except that in the arc
case, the default value is conditional.

Reported-by: Anton Kolesov <Anton.Kolesov@synopsys.com>
[yann.morin.1998@free.fr: indepently re-done a patch similar to the one
 Thomas made on his own]
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/Config.in.arc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Peter Korsgaard Sept. 11, 2014, 8:53 p.m. UTC | #1 
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Due to a kconfig limitation, we can't select a no-prompt symbol that
 > gets its dependencies by being conditionally re-defined in one or more
 > if-blocks, like we currently do for BR2_ARCH_HAS_ATOMICS.

 > As a workaround to this issue, we just redefine that symbol in the arc
 > if-block, like we do for all other architectures, except that in the arc
 > case, the default value is conditional.

 > Reported-by: Anton Kolesov <Anton.Kolesov@synopsys.com>
 > [yann.morin.1998@free.fr: indepently re-done a patch similar to the one
 >  Thomas made on his own]
 > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
 > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 > Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed, thanks.
diff mbox

Patch

diff --git a/arch/Config.in.arc b/arch/Config.in.arc
index 8a7f290..fcb5d7d 100644
--- a/arch/Config.in.arc
+++ b/arch/Config.in.arc
@@ -1,7 +1,9 @@ 
 # Choise of atomic instructions presence
 config BR2_ARC_ATOMIC_EXT
 	bool "Atomic extension (LLOCK/SCOND instructions)"
-	select BR2_ARCH_HAS_ATOMICS
+
+config BR2_ARCH_HAS_ATOMICS
+	default y if BR2_ARC_ATOMIC_EXT
 
 config BR2_ARCH
 	default "arc"	if BR2_arcle